Re: [PATCH 2/3] mm, page_poison: use static key more efficiently

2020-11-11 Thread Luis Chamberlain
On Fri, Oct 30, 2020 at 11:56:48PM +0100, Vlastimil Babka wrote: > On 10/30/20 5:27 PM, Luis Chamberlain wrote: > > On Mon, Oct 26, 2020 at 06:33:57PM +0100, Vlastimil Babka wrote: > > > Commit 11c9c7edae06 ("mm/page_poison.c: replace bool variable with static > > > key") > > > changed page_poison

Re: [PATCH 2/3] mm, page_poison: use static key more efficiently

2020-10-30 Thread Vlastimil Babka
On 10/30/20 5:27 PM, Luis Chamberlain wrote: On Mon, Oct 26, 2020 at 06:33:57PM +0100, Vlastimil Babka wrote: Commit 11c9c7edae06 ("mm/page_poison.c: replace bool variable with static key") changed page_poisoning_enabled() to a static key check. However, the function is not inlined, so each chec

Re: [PATCH 2/3] mm, page_poison: use static key more efficiently

2020-10-30 Thread Luis Chamberlain
On Mon, Oct 26, 2020 at 06:33:57PM +0100, Vlastimil Babka wrote: > Commit 11c9c7edae06 ("mm/page_poison.c: replace bool variable with static > key") > changed page_poisoning_enabled() to a static key check. However, the function > is not inlined, so each check still involves a function call with o

Re: [PATCH 2/3] mm, page_poison: use static key more efficiently

2020-10-27 Thread David Hildenbrand
On 26.10.20 18:33, Vlastimil Babka wrote: Commit 11c9c7edae06 ("mm/page_poison.c: replace bool variable with static key") changed page_poisoning_enabled() to a static key check. However, the function is not inlined, so each check still involves a function call with overhead not eliminated when pa

[PATCH 2/3] mm, page_poison: use static key more efficiently

2020-10-26 Thread Vlastimil Babka
Commit 11c9c7edae06 ("mm/page_poison.c: replace bool variable with static key") changed page_poisoning_enabled() to a static key check. However, the function is not inlined, so each check still involves a function call with overhead not eliminated when page poisoning is disabled. Analogically to h