Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-21 Thread Michal Hocko
On Mon 20-01-14 21:16:36, Hugh Dickins wrote: > On Fri, 17 Jan 2014, Michal Hocko wrote: > > On Thu 16-01-14 11:15:36, Hugh Dickins wrote: > > > > > I don't believe 19f39402864e was responsible for a reference leak, > > > that came later. But I think it was responsible for the original > > >

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-21 Thread Michal Hocko
On Mon 20-01-14 21:16:36, Hugh Dickins wrote: On Fri, 17 Jan 2014, Michal Hocko wrote: On Thu 16-01-14 11:15:36, Hugh Dickins wrote: I don't believe 19f39402864e was responsible for a reference leak, that came later. But I think it was responsible for the original endless iteration

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-20 Thread Hugh Dickins
On Fri, 17 Jan 2014, Michal Hocko wrote: > On Thu 16-01-14 11:15:36, Hugh Dickins wrote: > > > I don't believe 19f39402864e was responsible for a reference leak, > > that came later. But I think it was responsible for the original > > endless iteration (shrink_zone going around and around

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-20 Thread Hugh Dickins
On Fri, 17 Jan 2014, Michal Hocko wrote: On Thu 16-01-14 11:15:36, Hugh Dickins wrote: I don't believe 19f39402864e was responsible for a reference leak, that came later. But I think it was responsible for the original endless iteration (shrink_zone going around and around getting root

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-17 Thread Michal Hocko
On Thu 16-01-14 11:15:36, Hugh Dickins wrote: > On Thu, 16 Jan 2014, Michal Hocko wrote: > > From 543df5c82f6eec622f669ea322ba6ff03924fded Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Thu, 16 Jan 2014 16:17:13 +0100 > > Subject: [PATCH] memcg: fix css reference leak from

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-17 Thread Michal Hocko
On Thu 16-01-14 11:15:36, Hugh Dickins wrote: On Thu, 16 Jan 2014, Michal Hocko wrote: From 543df5c82f6eec622f669ea322ba6ff03924fded Mon Sep 17 00:00:00 2001 From: Michal Hocko mho...@suse.cz Date: Thu, 16 Jan 2014 16:17:13 +0100 Subject: [PATCH] memcg: fix css reference leak from

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-16 Thread Hugh Dickins
On Thu, 16 Jan 2014, Michal Hocko wrote: > From 543df5c82f6eec622f669ea322ba6ff03924fded Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Thu, 16 Jan 2014 16:17:13 +0100 > Subject: [PATCH] memcg: fix css reference leak from mem_cgroup_iter > > 19f39402864e (memcg: simplify mem_cgroup_iter)

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-16 Thread Michal Hocko
On Thu 16-01-14 09:17:38, Michal Hocko wrote: > On Wed 15-01-14 13:24:34, Hugh Dickins wrote: > > On Wed, 15 Jan 2014, Michal Hocko wrote: [...] > > > From 560924e86059947ab9418732cb329ad149dd8f6a Mon Sep 17 00:00:00 2001 > > > From: Michal Hocko > > > Date: Wed, 15 Jan 2014 11:52:09 +0100 > > >

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-16 Thread Michal Hocko
On Wed 15-01-14 13:24:34, Hugh Dickins wrote: > On Wed, 15 Jan 2014, Michal Hocko wrote: > > On Wed 15-01-14 10:58:29, Michal Hocko wrote: > > > On Tue 14-01-14 12:42:28, Hugh Dickins wrote: > > > > On Tue, 14 Jan 2014, Michal Hocko wrote: > > [...] > > > > > Ouch. And thinking about this shows

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-16 Thread Michal Hocko
On Wed 15-01-14 13:24:34, Hugh Dickins wrote: On Wed, 15 Jan 2014, Michal Hocko wrote: On Wed 15-01-14 10:58:29, Michal Hocko wrote: On Tue 14-01-14 12:42:28, Hugh Dickins wrote: On Tue, 14 Jan 2014, Michal Hocko wrote: [...] Ouch. And thinking about this shows that out_css_put is

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-16 Thread Michal Hocko
On Thu 16-01-14 09:17:38, Michal Hocko wrote: On Wed 15-01-14 13:24:34, Hugh Dickins wrote: On Wed, 15 Jan 2014, Michal Hocko wrote: [...] From 560924e86059947ab9418732cb329ad149dd8f6a Mon Sep 17 00:00:00 2001 From: Michal Hocko mho...@suse.cz Date: Wed, 15 Jan 2014 11:52:09 +0100

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-16 Thread Hugh Dickins
On Thu, 16 Jan 2014, Michal Hocko wrote: From 543df5c82f6eec622f669ea322ba6ff03924fded Mon Sep 17 00:00:00 2001 From: Michal Hocko mho...@suse.cz Date: Thu, 16 Jan 2014 16:17:13 +0100 Subject: [PATCH] memcg: fix css reference leak from mem_cgroup_iter 19f39402864e (memcg: simplify

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-15 Thread Hugh Dickins
On Wed, 15 Jan 2014, Michal Hocko wrote: > On Wed 15-01-14 10:58:29, Michal Hocko wrote: > > On Tue 14-01-14 12:42:28, Hugh Dickins wrote: > > > On Tue, 14 Jan 2014, Michal Hocko wrote: > [...] > > > > Ouch. And thinking about this shows that out_css_put is broken as well > > > > for subtree walks

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-15 Thread Michal Hocko
On Wed 15-01-14 10:58:29, Michal Hocko wrote: > On Tue 14-01-14 12:42:28, Hugh Dickins wrote: > > On Tue, 14 Jan 2014, Michal Hocko wrote: [...] > > > Ouch. And thinking about this shows that out_css_put is broken as well > > > for subtree walks (those that do not start at root_mem_cgroup level).

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-15 Thread Michal Hocko
On Tue 14-01-14 12:42:28, Hugh Dickins wrote: > On Tue, 14 Jan 2014, Michal Hocko wrote: > > On Tue 14-01-14 14:27:27, Michal Hocko wrote: > > > On Mon 13-01-14 17:52:30, Hugh Dickins wrote: > > > > On one home machine I can easily reproduce (by rmdir of memcgdir during > > > > reclaim) multiple

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-15 Thread Michal Hocko
On Tue 14-01-14 12:42:28, Hugh Dickins wrote: On Tue, 14 Jan 2014, Michal Hocko wrote: On Tue 14-01-14 14:27:27, Michal Hocko wrote: On Mon 13-01-14 17:52:30, Hugh Dickins wrote: On one home machine I can easily reproduce (by rmdir of memcgdir during reclaim) multiple processes stuck

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-15 Thread Michal Hocko
On Wed 15-01-14 10:58:29, Michal Hocko wrote: On Tue 14-01-14 12:42:28, Hugh Dickins wrote: On Tue, 14 Jan 2014, Michal Hocko wrote: [...] Ouch. And thinking about this shows that out_css_put is broken as well for subtree walks (those that do not start at root_mem_cgroup level). We

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-15 Thread Hugh Dickins
On Wed, 15 Jan 2014, Michal Hocko wrote: On Wed 15-01-14 10:58:29, Michal Hocko wrote: On Tue 14-01-14 12:42:28, Hugh Dickins wrote: On Tue, 14 Jan 2014, Michal Hocko wrote: [...] Ouch. And thinking about this shows that out_css_put is broken as well for subtree walks (those that do

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-14 Thread Hugh Dickins
On Tue, 14 Jan 2014, Michal Hocko wrote: > On Tue 14-01-14 14:27:27, Michal Hocko wrote: > > On Mon 13-01-14 17:52:30, Hugh Dickins wrote: > > > On one home machine I can easily reproduce (by rmdir of memcgdir during > > > reclaim) multiple processes stuck looping forever in mem_cgroup_iter(): > >

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-14 Thread Michal Hocko
On Tue 14-01-14 14:27:27, Michal Hocko wrote: > On Mon 13-01-14 17:52:30, Hugh Dickins wrote: > > On one home machine I can easily reproduce (by rmdir of memcgdir during > > reclaim) multiple processes stuck looping forever in mem_cgroup_iter(): > > __mem_cgroup_iter_next() keeps selecting the

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-14 Thread Michal Hocko
On Tue 14-01-14 14:27:27, Michal Hocko wrote: > On Mon 13-01-14 17:52:30, Hugh Dickins wrote: > > On one home machine I can easily reproduce (by rmdir of memcgdir during > > reclaim) multiple processes stuck looping forever in mem_cgroup_iter(): > > __mem_cgroup_iter_next() keeps selecting the

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-14 Thread Michal Hocko
On Mon 13-01-14 17:52:30, Hugh Dickins wrote: > On one home machine I can easily reproduce (by rmdir of memcgdir during > reclaim) multiple processes stuck looping forever in mem_cgroup_iter(): > __mem_cgroup_iter_next() keeps selecting the memcg being destroyed, fails > to tryget it, returns NULL

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-14 Thread Michal Hocko
On Mon 13-01-14 17:52:30, Hugh Dickins wrote: On one home machine I can easily reproduce (by rmdir of memcgdir during reclaim) multiple processes stuck looping forever in mem_cgroup_iter(): __mem_cgroup_iter_next() keeps selecting the memcg being destroyed, fails to tryget it, returns NULL to

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-14 Thread Michal Hocko
On Tue 14-01-14 14:27:27, Michal Hocko wrote: On Mon 13-01-14 17:52:30, Hugh Dickins wrote: On one home machine I can easily reproduce (by rmdir of memcgdir during reclaim) multiple processes stuck looping forever in mem_cgroup_iter(): __mem_cgroup_iter_next() keeps selecting the memcg

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-14 Thread Michal Hocko
On Tue 14-01-14 14:27:27, Michal Hocko wrote: On Mon 13-01-14 17:52:30, Hugh Dickins wrote: On one home machine I can easily reproduce (by rmdir of memcgdir during reclaim) multiple processes stuck looping forever in mem_cgroup_iter(): __mem_cgroup_iter_next() keeps selecting the memcg

Re: [PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-14 Thread Hugh Dickins
On Tue, 14 Jan 2014, Michal Hocko wrote: On Tue 14-01-14 14:27:27, Michal Hocko wrote: On Mon 13-01-14 17:52:30, Hugh Dickins wrote: On one home machine I can easily reproduce (by rmdir of memcgdir during reclaim) multiple processes stuck looping forever in mem_cgroup_iter():

[PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-13 Thread Hugh Dickins
On one home machine I can easily reproduce (by rmdir of memcgdir during reclaim) multiple processes stuck looping forever in mem_cgroup_iter(): __mem_cgroup_iter_next() keeps selecting the memcg being destroyed, fails to tryget it, returns NULL to mem_cgroup_iter(), which goes around again. It's

[PATCH 2/3] mm/memcg: fix endless iteration in reclaim

2014-01-13 Thread Hugh Dickins
On one home machine I can easily reproduce (by rmdir of memcgdir during reclaim) multiple processes stuck looping forever in mem_cgroup_iter(): __mem_cgroup_iter_next() keeps selecting the memcg being destroyed, fails to tryget it, returns NULL to mem_cgroup_iter(), which goes around again. It's