Re: [PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list

2013-05-01 Thread Mel Gorman
On Wed, May 01, 2013 at 04:14:16PM +0800, Ric Mason wrote: > On 05/01/2013 04:06 PM, Mel Gorman wrote: > >On Wed, May 01, 2013 at 01:41:34PM +0800, Sam Ben wrote: > >>Hi Mel, > >>On 04/30/2013 12:31 AM, Mel Gorman wrote: > >>>If a page is on a pagevec then it is !PageLRU and mark_page_accessed() >

Re: [PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list

2013-05-01 Thread Ric Mason
On 05/01/2013 04:06 PM, Mel Gorman wrote: On Wed, May 01, 2013 at 01:41:34PM +0800, Sam Ben wrote: Hi Mel, On 04/30/2013 12:31 AM, Mel Gorman wrote: If a page is on a pagevec then it is !PageLRU and mark_page_accessed() may fail to move a page to the active list as expected. Now that the LRU

Re: [PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list

2013-05-01 Thread Mel Gorman
On Wed, May 01, 2013 at 01:41:34PM +0800, Sam Ben wrote: > Hi Mel, > On 04/30/2013 12:31 AM, Mel Gorman wrote: > >If a page is on a pagevec then it is !PageLRU and mark_page_accessed() > >may fail to move a page to the active list as expected. Now that the > >LRU is selected at LRU drain time,

Re: [PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list

2013-05-01 Thread Mel Gorman
On Wed, May 01, 2013 at 01:41:34PM +0800, Sam Ben wrote: Hi Mel, On 04/30/2013 12:31 AM, Mel Gorman wrote: If a page is on a pagevec then it is !PageLRU and mark_page_accessed() may fail to move a page to the active list as expected. Now that the LRU is selected at LRU drain time, mark pages

Re: [PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list

2013-05-01 Thread Ric Mason
On 05/01/2013 04:06 PM, Mel Gorman wrote: On Wed, May 01, 2013 at 01:41:34PM +0800, Sam Ben wrote: Hi Mel, On 04/30/2013 12:31 AM, Mel Gorman wrote: If a page is on a pagevec then it is !PageLRU and mark_page_accessed() may fail to move a page to the active list as expected. Now that the LRU

Re: [PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list

2013-05-01 Thread Mel Gorman
On Wed, May 01, 2013 at 04:14:16PM +0800, Ric Mason wrote: On 05/01/2013 04:06 PM, Mel Gorman wrote: On Wed, May 01, 2013 at 01:41:34PM +0800, Sam Ben wrote: Hi Mel, On 04/30/2013 12:31 AM, Mel Gorman wrote: If a page is on a pagevec then it is !PageLRU and mark_page_accessed() may fail to

Re: [PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list

2013-04-30 Thread Sam Ben
Hi Mel, On 04/30/2013 12:31 AM, Mel Gorman wrote: If a page is on a pagevec then it is !PageLRU and mark_page_accessed() may fail to move a page to the active list as expected. Now that the LRU is selected at LRU drain time, mark pages PageActive if they are on a pagevec so it gets moved to the

Re: [PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list

2013-04-30 Thread Sam Ben
Hi Mel, On 04/30/2013 12:31 AM, Mel Gorman wrote: If a page is on a pagevec then it is !PageLRU and mark_page_accessed() may fail to move a page to the active list as expected. Now that the LRU is selected at LRU drain time, mark pages PageActive if they are on a pagevec so it gets moved to the

Re: [PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list

2013-04-29 Thread Mel Gorman
On Mon, Apr 29, 2013 at 01:12:03PM -0400, Rik van Riel wrote: > On 04/29/2013 12:31 PM, Mel Gorman wrote: > > >A PageActive page is now added to the inactivate list. > > > >While this looks strange, I think it is sufficiently harmless that additional > >barriers to address the case is not

Re: [PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list

2013-04-29 Thread Rik van Riel
On 04/29/2013 12:31 PM, Mel Gorman wrote: A PageActive page is now added to the inactivate list. While this looks strange, I think it is sufficiently harmless that additional barriers to address the case is not justified. Unfortunately, while I never witnessed it myself, these parallel

[PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list

2013-04-29 Thread Mel Gorman
If a page is on a pagevec then it is !PageLRU and mark_page_accessed() may fail to move a page to the active list as expected. Now that the LRU is selected at LRU drain time, mark pages PageActive if they are on a pagevec so it gets moved to the correct list at LRU drain time. Using a debugging

[PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list

2013-04-29 Thread Mel Gorman
If a page is on a pagevec then it is !PageLRU and mark_page_accessed() may fail to move a page to the active list as expected. Now that the LRU is selected at LRU drain time, mark pages PageActive if they are on a pagevec so it gets moved to the correct list at LRU drain time. Using a debugging

Re: [PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list

2013-04-29 Thread Rik van Riel
On 04/29/2013 12:31 PM, Mel Gorman wrote: A PageActive page is now added to the inactivate list. While this looks strange, I think it is sufficiently harmless that additional barriers to address the case is not justified. Unfortunately, while I never witnessed it myself, these parallel

Re: [PATCH 2/3] mm: Ensure that mark_page_accessed moves pages to the active list

2013-04-29 Thread Mel Gorman
On Mon, Apr 29, 2013 at 01:12:03PM -0400, Rik van Riel wrote: On 04/29/2013 12:31 PM, Mel Gorman wrote: A PageActive page is now added to the inactivate list. While this looks strange, I think it is sufficiently harmless that additional barriers to address the case is not justified.