Re: [PATCH 2/3] mmc: dw_mmc: simplify the SDMMC_CLKEN_LOW_PWR logic

2015-08-17 Thread Alim Akhtar
Hi Michal, On Mon, Aug 17, 2015 at 8:25 PM, Michal Suchanek wrote: > Hello, > > On 17 August 2015 at 16:42, Alim Akhtar wrote: >> HI >> >> On Mon, Aug 17, 2015 at 4:56 PM, Jaehoon Chung >> wrote: >>> On 08/17/2015 02:52 PM, Michal Suchanek wrote: Hello, On 17 August 2015 at

Re: [PATCH 2/3] mmc: dw_mmc: simplify the SDMMC_CLKEN_LOW_PWR logic

2015-08-17 Thread Michal Suchanek
Hello, On 17 August 2015 at 16:42, Alim Akhtar wrote: > HI > > On Mon, Aug 17, 2015 at 4:56 PM, Jaehoon Chung wrote: >> On 08/17/2015 02:52 PM, Michal Suchanek wrote: >>> Hello, >>> >>> On 17 August 2015 at 03:55, Jaehoon Chung wrote: Hi, Michal. On 08/12/2015 09:23 PM, Michal

Re: [PATCH 2/3] mmc: dw_mmc: simplify the SDMMC_CLKEN_LOW_PWR logic

2015-08-17 Thread Alim Akhtar
HI On Mon, Aug 17, 2015 at 4:56 PM, Jaehoon Chung wrote: > On 08/17/2015 02:52 PM, Michal Suchanek wrote: >> Hello, >> >> On 17 August 2015 at 03:55, Jaehoon Chung wrote: >>> Hi, Michal. >>> >>> On 08/12/2015 09:23 PM, Michal Suchanek wrote: The driver has open-coded test for SDIO cards.

Re: [PATCH 2/3] mmc: dw_mmc: simplify the SDMMC_CLKEN_LOW_PWR logic

2015-08-17 Thread Jaehoon Chung
On 08/17/2015 02:52 PM, Michal Suchanek wrote: > Hello, > > On 17 August 2015 at 03:55, Jaehoon Chung wrote: >> Hi, Michal. >> >> On 08/12/2015 09:23 PM, Michal Suchanek wrote: >>> The driver has open-coded test for SDIO cards. Use the mmc core provided >>> MMC_QUIRK_BROKEN_CLK_GATING flag

Re: [PATCH 2/3] mmc: dw_mmc: simplify the SDMMC_CLKEN_LOW_PWR logic

2015-08-17 Thread Jaehoon Chung
On 08/17/2015 02:52 PM, Michal Suchanek wrote: Hello, On 17 August 2015 at 03:55, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Michal. On 08/12/2015 09:23 PM, Michal Suchanek wrote: The driver has open-coded test for SDIO cards. Use the mmc core provided MMC_QUIRK_BROKEN_CLK_GATING

Re: [PATCH 2/3] mmc: dw_mmc: simplify the SDMMC_CLKEN_LOW_PWR logic

2015-08-17 Thread Alim Akhtar
HI On Mon, Aug 17, 2015 at 4:56 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 08/17/2015 02:52 PM, Michal Suchanek wrote: Hello, On 17 August 2015 at 03:55, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Michal. On 08/12/2015 09:23 PM, Michal Suchanek wrote: The driver has

Re: [PATCH 2/3] mmc: dw_mmc: simplify the SDMMC_CLKEN_LOW_PWR logic

2015-08-17 Thread Alim Akhtar
Hi Michal, On Mon, Aug 17, 2015 at 8:25 PM, Michal Suchanek hramr...@gmail.com wrote: Hello, On 17 August 2015 at 16:42, Alim Akhtar alim.akh...@gmail.com wrote: HI On Mon, Aug 17, 2015 at 4:56 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 08/17/2015 02:52 PM, Michal Suchanek

Re: [PATCH 2/3] mmc: dw_mmc: simplify the SDMMC_CLKEN_LOW_PWR logic

2015-08-17 Thread Michal Suchanek
Hello, On 17 August 2015 at 16:42, Alim Akhtar alim.akh...@gmail.com wrote: HI On Mon, Aug 17, 2015 at 4:56 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 08/17/2015 02:52 PM, Michal Suchanek wrote: Hello, On 17 August 2015 at 03:55, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi,

Re: [PATCH 2/3] mmc: dw_mmc: simplify the SDMMC_CLKEN_LOW_PWR logic

2015-08-16 Thread Michal Suchanek
Hello, On 17 August 2015 at 03:55, Jaehoon Chung wrote: > Hi, Michal. > > On 08/12/2015 09:23 PM, Michal Suchanek wrote: >> The driver has open-coded test for SDIO cards. Use the mmc core provided >> MMC_QUIRK_BROKEN_CLK_GATING flag instead. > > Did you use the clock-gating for SDIO cards? >

Re: [PATCH 2/3] mmc: dw_mmc: simplify the SDMMC_CLKEN_LOW_PWR logic

2015-08-16 Thread Jaehoon Chung
Hi, Michal. On 08/12/2015 09:23 PM, Michal Suchanek wrote: > The driver has open-coded test for SDIO cards. Use the mmc core provided > MMC_QUIRK_BROKEN_CLK_GATING flag instead. Did you use the clock-gating for SDIO cards? Doesn't MMC_CAP_SDIO_IRQ bit set? Which case is broken? Could you explain

Re: [PATCH 2/3] mmc: dw_mmc: simplify the SDMMC_CLKEN_LOW_PWR logic

2015-08-16 Thread Jaehoon Chung
Hi, Michal. On 08/12/2015 09:23 PM, Michal Suchanek wrote: The driver has open-coded test for SDIO cards. Use the mmc core provided MMC_QUIRK_BROKEN_CLK_GATING flag instead. Did you use the clock-gating for SDIO cards? Doesn't MMC_CAP_SDIO_IRQ bit set? Which case is broken? Could you explain

Re: [PATCH 2/3] mmc: dw_mmc: simplify the SDMMC_CLKEN_LOW_PWR logic

2015-08-16 Thread Michal Suchanek
Hello, On 17 August 2015 at 03:55, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Michal. On 08/12/2015 09:23 PM, Michal Suchanek wrote: The driver has open-coded test for SDIO cards. Use the mmc core provided MMC_QUIRK_BROKEN_CLK_GATING flag instead. Did you use the clock-gating for SDIO