On Tue, 4 Jul 2017, Cyrille Pitchen wrote:
Hi Cyrille,
Thanks for all the great feedback. Clearly, I've got some work to do.
Please see my comments inline.
Matthew Gerlach
Hi Matthew,
Le 26/06/2017 à 18:13, matthew.gerl...@linux.intel.com a écrit :
From: Matthew Gerlach
On Tue, 4 Jul 2017, Cyrille Pitchen wrote:
Hi Cyrille,
Thanks for all the great feedback. Clearly, I've got some work to do.
Please see my comments inline.
Matthew Gerlach
Hi Matthew,
Le 26/06/2017 à 18:13, matthew.gerl...@linux.intel.com a écrit :
From: Matthew Gerlach
On 4 July 2017 at 02:00, Cyrille Pitchen wrote:
> Hi Matthew,
>
>
> Le 26/06/2017 à 18:13, matthew.gerl...@linux.intel.com a écrit :
>> From: Matthew Gerlach
>> +static int altera_quadspi_setup_banks(struct device *dev,
>> +
On 4 July 2017 at 02:00, Cyrille Pitchen wrote:
> Hi Matthew,
>
>
> Le 26/06/2017 à 18:13, matthew.gerl...@linux.intel.com a écrit :
>> From: Matthew Gerlach
>> +static int altera_quadspi_setup_banks(struct device *dev,
>> + u32 bank, struct device_node *np)
>>
Hi Matthew,
Le 26/06/2017 à 18:13, matthew.gerl...@linux.intel.com a écrit :
> From: Matthew Gerlach
>
> Signed-off-by: Matthew Gerlach
> ---
> MAINTAINERS | 7 +
> drivers/mtd/spi-nor/Kconfig
Hi Matthew,
Le 26/06/2017 à 18:13, matthew.gerl...@linux.intel.com a écrit :
> From: Matthew Gerlach
>
> Signed-off-by: Matthew Gerlach
> ---
> MAINTAINERS | 7 +
> drivers/mtd/spi-nor/Kconfig | 5 +
> drivers/mtd/spi-nor/Makefile | 4 +-
>
On Tue, 27 Jun 2017, Marek Vasut wrote:
On 06/27/2017 07:26 PM, matthew.gerl...@linux.intel.com wrote:
[...]
+#ifndef __ALTERA_QUADSPI_H
+#define __ALTERA_QUADSPI_H
+
+#include
+
+#define ALTERA_QUADSPI_FL_BITREV_READ BIT(0)
+#define ALTERA_QUADSPI_FL_BITREV_WRITE BIT(1)
+
+#define
On Tue, 27 Jun 2017, Marek Vasut wrote:
On 06/27/2017 07:26 PM, matthew.gerl...@linux.intel.com wrote:
[...]
+#ifndef __ALTERA_QUADSPI_H
+#define __ALTERA_QUADSPI_H
+
+#include
+
+#define ALTERA_QUADSPI_FL_BITREV_READ BIT(0)
+#define ALTERA_QUADSPI_FL_BITREV_WRITE BIT(1)
+
+#define
On 06/27/2017 07:26 PM, matthew.gerl...@linux.intel.com wrote:
[...]
> +#ifndef __ALTERA_QUADSPI_H
> +#define __ALTERA_QUADSPI_H
> +
> +#include
> +
> +#define ALTERA_QUADSPI_FL_BITREV_READ BIT(0)
> +#define ALTERA_QUADSPI_FL_BITREV_WRITE BIT(1)
> +
>
On 06/27/2017 07:26 PM, matthew.gerl...@linux.intel.com wrote:
[...]
> +#ifndef __ALTERA_QUADSPI_H
> +#define __ALTERA_QUADSPI_H
> +
> +#include
> +
> +#define ALTERA_QUADSPI_FL_BITREV_READ BIT(0)
> +#define ALTERA_QUADSPI_FL_BITREV_WRITE BIT(1)
> +
>
On Tue, 27 Jun 2017, Marek Vasut wrote:
On 06/27/2017 04:57 PM, matthew.gerl...@linux.intel.com wrote:
[...]
+static int altera_quadspi_read_reg(struct spi_nor *nor, u8 opcode,
u8 *val,
+ int len)
+{
+struct altera_quadspi_flash *flash = nor->priv;
+struct
On Tue, 27 Jun 2017, Marek Vasut wrote:
On 06/27/2017 04:57 PM, matthew.gerl...@linux.intel.com wrote:
[...]
+static int altera_quadspi_read_reg(struct spi_nor *nor, u8 opcode,
u8 *val,
+ int len)
+{
+struct altera_quadspi_flash *flash = nor->priv;
+struct
On 06/27/2017 04:57 PM, matthew.gerl...@linux.intel.com wrote:
[...]
>>> +static int altera_quadspi_read_reg(struct spi_nor *nor, u8 opcode,
>>> u8 *val,
>>> + int len)
>>> +{
>>> +struct altera_quadspi_flash *flash = nor->priv;
>>> +struct altera_quadspi *q = flash->q;
On 06/27/2017 04:57 PM, matthew.gerl...@linux.intel.com wrote:
[...]
>>> +static int altera_quadspi_read_reg(struct spi_nor *nor, u8 opcode,
>>> u8 *val,
>>> + int len)
>>> +{
>>> +struct altera_quadspi_flash *flash = nor->priv;
>>> +struct altera_quadspi *q = flash->q;
On Tue, 27 Jun 2017, Marek Vasut wrote:
Hi Marek,
Thanks again for the valuable feedback. See my comments below.
Matthew Gerlach
On 06/26/2017 06:13 PM, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
Signed-off-by: Matthew Gerlach
On Tue, 27 Jun 2017, Marek Vasut wrote:
Hi Marek,
Thanks again for the valuable feedback. See my comments below.
Matthew Gerlach
On 06/26/2017 06:13 PM, matthew.gerl...@linux.intel.com wrote:
From: Matthew Gerlach
Signed-off-by: Matthew Gerlach
---
MAINTAINERS
On 06/26/2017 06:13 PM, matthew.gerl...@linux.intel.com wrote:
> From: Matthew Gerlach
>
> Signed-off-by: Matthew Gerlach
> ---
> MAINTAINERS | 7 +
> drivers/mtd/spi-nor/Kconfig | 5 +
>
On 06/26/2017 06:13 PM, matthew.gerl...@linux.intel.com wrote:
> From: Matthew Gerlach
>
> Signed-off-by: Matthew Gerlach
> ---
> MAINTAINERS | 7 +
> drivers/mtd/spi-nor/Kconfig | 5 +
> drivers/mtd/spi-nor/Makefile | 4 +-
>
Hi Matthew,
[auto build test WARNING on spi-nor/next]
[also build test WARNING on v4.12-rc7 next-20170627]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
Hi Matthew,
[auto build test WARNING on spi-nor/next]
[also build test WARNING on v4.12-rc7 next-20170627]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
From: Matthew Gerlach
Signed-off-by: Matthew Gerlach
---
MAINTAINERS | 7 +
drivers/mtd/spi-nor/Kconfig | 5 +
drivers/mtd/spi-nor/Makefile | 4 +-
From: Matthew Gerlach
Signed-off-by: Matthew Gerlach
---
MAINTAINERS | 7 +
drivers/mtd/spi-nor/Kconfig | 5 +
drivers/mtd/spi-nor/Makefile | 4 +-
drivers/mtd/spi-nor/altera-quadspi.c | 676 +++
22 matches
Mail list logo