Re: [PATCH 2/3] power: supply: New driver for LEGO MINDSTORMS EV3 battery

2017-04-11 Thread Sebastian Reichel
Hi, Driver looks fine. One minor thing, though: On Mon, Apr 03, 2017 at 03:23:48PM -0500, David Lechner wrote: > [...] > > + batt->psy = power_supply_register(dev, _ev3_battery_desc, > _cfg); > + err = PTR_ERR_OR_ZERO(batt->psy); > + if (err) { > + dev_err(dev, "failed

Re: [PATCH 2/3] power: supply: New driver for LEGO MINDSTORMS EV3 battery

2017-04-11 Thread Sebastian Reichel
Hi, Driver looks fine. One minor thing, though: On Mon, Apr 03, 2017 at 03:23:48PM -0500, David Lechner wrote: > [...] > > + batt->psy = power_supply_register(dev, _ev3_battery_desc, > _cfg); > + err = PTR_ERR_OR_ZERO(batt->psy); > + if (err) { > + dev_err(dev, "failed

[PATCH 2/3] power: supply: New driver for LEGO MINDSTORMS EV3 battery

2017-04-03 Thread David Lechner
This adds a new driver for the LEGO MINDSTORMS EV3 battery. The EV3 is an embedded ARM device that can use 6 AA batteries or a special rechargeable Li-ion battery pack. The rechargeable battery pack presses a special key switch in the battery compartment to indicate that it is present. The EV3 is

[PATCH 2/3] power: supply: New driver for LEGO MINDSTORMS EV3 battery

2017-04-03 Thread David Lechner
This adds a new driver for the LEGO MINDSTORMS EV3 battery. The EV3 is an embedded ARM device that can use 6 AA batteries or a special rechargeable Li-ion battery pack. The rechargeable battery pack presses a special key switch in the battery compartment to indicate that it is present. The EV3 is