Re: [PATCH 2/3] sched/fair: util_est: update before schedutil

2018-05-11 Thread Patrick Bellasi
On 11-May 11:14, Viresh Kumar wrote: > On 10-05-18, 16:05, Patrick Bellasi wrote: > > When a task is enqueue the estimated utilization of a CPU is updated > > to better support the selection of the required frequency. > > However, schedutil is (implicitly) updated by update_load_avg() which > > alw

Re: [PATCH 2/3] sched/fair: util_est: update before schedutil

2018-05-10 Thread Viresh Kumar
On 10-05-18, 16:05, Patrick Bellasi wrote: > When a task is enqueue the estimated utilization of a CPU is updated > to better support the selection of the required frequency. > However, schedutil is (implicitly) updated by update_load_avg() which > always happens before util_est_{en,de}queue(), thu

Re: [PATCH 2/3] sched/fair: util_est: update before schedutil

2018-05-10 Thread Peter Zijlstra
On Thu, May 10, 2018 at 04:05:52PM +0100, Patrick Bellasi wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 1f6a23a5b451..01dfc47541e6 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -5356,6 +5356,9 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p,

[PATCH 2/3] sched/fair: util_est: update before schedutil

2018-05-10 Thread Patrick Bellasi
When a task is enqueue the estimated utilization of a CPU is updated to better support the selection of the required frequency. However, schedutil is (implicitly) updated by update_load_avg() which always happens before util_est_{en,de}queue(), thus potentially introducing a latency between estimat