Re: [PATCH 2/3] scsi:ufs:add ufs node property for hi3660

2017-06-09 Thread Guodong Xu
Bu Tao, One other issue: the 'sender' of your patchset is "butao". For upstreaming purpose, it is recommended to use your full name, in "first name" + "Surname" format. In your case, you need to specify it in your commit message: $ git commit --amend --author="Bu Tao " You

Re: [PATCH 2/3] scsi:ufs:add ufs node property for hi3660

2017-06-09 Thread Guodong Xu
Bu Tao, One other issue: the 'sender' of your patchset is "butao". For upstreaming purpose, it is recommended to use your full name, in "first name" + "Surname" format. In your case, you need to specify it in your commit message: $ git commit --amend --author="Bu Tao " You may also want to add

Re: [PATCH 2/3] scsi:ufs:add ufs node property for hi3660

2017-06-09 Thread Guodong Xu
On Sat, Jun 10, 2017 at 9:20 AM, butao wrote: > add ufs node for hi3660 > > Signed-off-by: Bu Tao > --- > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 20 > 1 file changed, 20 insertions(+) > mode change 100644 => 100755

Re: [PATCH 2/3] scsi:ufs:add ufs node property for hi3660

2017-06-09 Thread Guodong Xu
On Sat, Jun 10, 2017 at 9:20 AM, butao wrote: > add ufs node for hi3660 > > Signed-off-by: Bu Tao > --- > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 20 > 1 file changed, 20 insertions(+) > mode change 100644 => 100755 arch/arm64/boot/dts/hisilicon/hi3660.dtsi Mode

Re: [PATCH 2/3] scsi:ufs:add ufs node property for hi3660

2017-06-09 Thread Guodong Xu
Bu Tao, 1. Subject line of this patch goes something like "arm64: dts: hi3660: add ufs support xxx" 2. Have you run "./scripts/get_maintainer.pl *.patch" to get the correct maintainers to include into your patch review? I don't think so. Because this is a dts change, however in your email's to/

Re: [PATCH 2/3] scsi:ufs:add ufs node property for hi3660

2017-06-09 Thread Guodong Xu
Bu Tao, 1. Subject line of this patch goes something like "arm64: dts: hi3660: add ufs support xxx" 2. Have you run "./scripts/get_maintainer.pl *.patch" to get the correct maintainers to include into your patch review? I don't think so. Because this is a dts change, however in your email's to/

[PATCH 2/3] scsi:ufs:add ufs node property for hi3660

2017-06-09 Thread butao
add ufs node for hi3660 Signed-off-by: Bu Tao --- arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 20 1 file changed, 20 insertions(+) mode change 100644 => 100755 arch/arm64/boot/dts/hisilicon/hi3660.dtsi diff --git

[PATCH 2/3] scsi:ufs:add ufs node property for hi3660

2017-06-09 Thread butao
add ufs node for hi3660 Signed-off-by: Bu Tao --- arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 20 1 file changed, 20 insertions(+) mode change 100644 => 100755 arch/arm64/boot/dts/hisilicon/hi3660.dtsi diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi