Re: [PATCH 2/3] soc: amazon: al-pos: Introduce Amazon's Annapurna Labs POS driver

2019-09-10 Thread Shenhar, Talel
On 9/9/2019 6:16 PM, Arnd Bergmann wrote: On Mon, Sep 9, 2019 at 4:11 PM Shenhar, Talel wrote: On 9/9/2019 4:41 PM, Arnd Bergmann wrote: In current implementation of v1, I am not doing any read barrier, Hence, using the non-relaxed will add unneeded memory barrier. I have no strong

Re: [PATCH 2/3] soc: amazon: al-pos: Introduce Amazon's Annapurna Labs POS driver

2019-09-09 Thread Arnd Bergmann
On Mon, Sep 9, 2019 at 4:11 PM Shenhar, Talel wrote: > On 9/9/2019 4:41 PM, Arnd Bergmann wrote: > > In current implementation of v1, I am not doing any read barrier, Hence, > using the non-relaxed will add unneeded memory barrier. > > I have no strong objection moving to the non-relaxed version

Re: [PATCH 2/3] soc: amazon: al-pos: Introduce Amazon's Annapurna Labs POS driver

2019-09-09 Thread Shenhar, Talel
On 9/9/2019 4:41 PM, Arnd Bergmann wrote: On Mon, Sep 9, 2019 at 1:13 PM Shenhar, Talel wrote: On 9/9/2019 12:44 PM, Arnd Bergmann wrote: On Mon, Sep 9, 2019 at 11:14 AM Talel Shenhar wrote: + writel_relaxed(0, pos->mmio_base + AL_POS_ERROR_LOG_1); Why do you require _relaxed()

Re: [PATCH 2/3] soc: amazon: al-pos: Introduce Amazon's Annapurna Labs POS driver

2019-09-09 Thread Arnd Bergmann
On Mon, Sep 9, 2019 at 1:13 PM Shenhar, Talel wrote: > On 9/9/2019 12:44 PM, Arnd Bergmann wrote: > > On Mon, Sep 9, 2019 at 11:14 AM Talel Shenhar wrote: > >> + writel_relaxed(0, pos->mmio_base + AL_POS_ERROR_LOG_1); > > Why do you require _relaxed() accessors here? Please add a comment

Re: [PATCH 2/3] soc: amazon: al-pos: Introduce Amazon's Annapurna Labs POS driver

2019-09-09 Thread kbuild test robot
Hi Talel, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.3-rc8 next-20190904] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/3] soc: amazon: al-pos: Introduce Amazon's Annapurna Labs POS driver

2019-09-09 Thread Shenhar, Talel
On 9/9/2019 12:44 PM, Arnd Bergmann wrote: On Mon, Sep 9, 2019 at 11:14 AM Talel Shenhar wrote: The Amazon's Annapurna Labs SoCs includes Point Of Serialization error logging unit that reports an error in case write error (e.g. attempt to write to a read only register). This patch introduces

Re: [PATCH 2/3] soc: amazon: al-pos: Introduce Amazon's Annapurna Labs POS driver

2019-09-09 Thread Arnd Bergmann
On Mon, Sep 9, 2019 at 11:14 AM Talel Shenhar wrote: > > The Amazon's Annapurna Labs SoCs includes Point Of Serialization error > logging unit that reports an error in case write error (e.g. attempt to > write to a read only register). > This patch introduces the support for this unit. > >

[PATCH 2/3] soc: amazon: al-pos: Introduce Amazon's Annapurna Labs POS driver

2019-09-09 Thread Talel Shenhar
The Amazon's Annapurna Labs SoCs includes Point Of Serialization error logging unit that reports an error in case write error (e.g. attempt to write to a read only register). This patch introduces the support for this unit. Signed-off-by: Talel Shenhar --- MAINTAINERS | 6 +++