Re: [PATCH 2/3] sound: enable interrupt after dma buffer initialization

2018-09-11 Thread Vinod
On 11-09-18, 14:58, Yu Zhao wrote: > On Tue, Sep 11, 2018 at 08:06:49AM +0200, Takashi Iwai wrote: > > On Mon, 10 Sep 2018 23:21:50 +0200, > > Yu Zhao wrote: > > > > > > In snd_hdac_bus_init_chip(), we enable interrupt before > > > snd_hdac_bus_init_cmd_io() initializing dma buffers. If irq has >

Re: [PATCH 2/3] sound: enable interrupt after dma buffer initialization

2018-09-11 Thread Yu Zhao
On Tue, Sep 11, 2018 at 08:06:49AM +0200, Takashi Iwai wrote: > On Mon, 10 Sep 2018 23:21:50 +0200, > Yu Zhao wrote: > > > > In snd_hdac_bus_init_chip(), we enable interrupt before > > snd_hdac_bus_init_cmd_io() initializing dma buffers. If irq has > > been acquired and irq handler uses the dma bu

Re: [PATCH 2/3] sound: enable interrupt after dma buffer initialization

2018-09-10 Thread Takashi Iwai
On Mon, 10 Sep 2018 23:21:50 +0200, Yu Zhao wrote: > > In snd_hdac_bus_init_chip(), we enable interrupt before > snd_hdac_bus_init_cmd_io() initializing dma buffers. If irq has > been acquired and irq handler uses the dma buffer, kernel may crash > when interrupt comes in. > > Fix the problem by

[PATCH 2/3] sound: enable interrupt after dma buffer initialization

2018-09-10 Thread Yu Zhao
In snd_hdac_bus_init_chip(), we enable interrupt before snd_hdac_bus_init_cmd_io() initializing dma buffers. If irq has been acquired and irq handler uses the dma buffer, kernel may crash when interrupt comes in. Fix the problem by postponing enabling irq after dma buffer initialization. And warn