Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-10 Thread chenfeng
On 2015/10/9 16:58, Dan Carpenter wrote: > On Fri, Oct 09, 2015 at 11:53:32AM +0300, Dan Carpenter wrote: >>> +out: >> >> Labels named "out" are bug prone because handling everything is harder >> than using named labels and unwinding one step at a time. The bug here >> is that we don't call

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-10 Thread chenfeng
On 2015/10/9 16:58, Dan Carpenter wrote: > On Fri, Oct 09, 2015 at 11:53:32AM +0300, Dan Carpenter wrote: >>> +out: >> >> Labels named "out" are bug prone because handling everything is harder >> than using named labels and unwinding one step at a time. The bug here >> is that we don't call

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-09 Thread xuyiping
On 2015/10/8 15:55, Chen Feng wrote: Signed-off-by: Chen Feng Signed-off-by: Yu Dongbin --- drivers/staging/android/ion/Kconfig| 7 + drivers/staging/android/ion/Makefile | 1 + drivers/staging/android/ion/hisilicon/Kconfig | 5 +

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-09 Thread Dan Carpenter
On Fri, Oct 09, 2015 at 11:53:32AM +0300, Dan Carpenter wrote: > > +out: > > Labels named "out" are bug prone because handling everything is harder > than using named labels and unwinding one step at a time. The bug here > is that we don't call ion_device_destroy(). > > > + for (i = 0; i <

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-09 Thread Dan Carpenter
On Thu, Oct 08, 2015 at 03:55:12PM +0800, Chen Feng wrote: > Signed-off-by: Chen Feng > Signed-off-by: Yu Dongbin > --- > drivers/staging/android/ion/Kconfig| 7 + > drivers/staging/android/ion/Makefile | 1 + > drivers/staging/android/ion/hisilicon/Kconfig

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-09 Thread Dan Carpenter
On Fri, Oct 09, 2015 at 11:53:32AM +0300, Dan Carpenter wrote: > > +out: > > Labels named "out" are bug prone because handling everything is harder > than using named labels and unwinding one step at a time. The bug here > is that we don't call ion_device_destroy(). > > > + for (i = 0; i <

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-09 Thread xuyiping
On 2015/10/8 15:55, Chen Feng wrote: Signed-off-by: Chen Feng Signed-off-by: Yu Dongbin --- drivers/staging/android/ion/Kconfig| 7 + drivers/staging/android/ion/Makefile | 1 +

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-09 Thread Dan Carpenter
On Thu, Oct 08, 2015 at 03:55:12PM +0800, Chen Feng wrote: > Signed-off-by: Chen Feng > Signed-off-by: Yu Dongbin > --- > drivers/staging/android/ion/Kconfig| 7 + > drivers/staging/android/ion/Makefile | 1 + >

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-08 Thread kbuild test robot
Hi Chen, [auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore] config: arm-allyesconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-08 Thread Greg KH
On Thu, Oct 08, 2015 at 03:55:12PM +0800, Chen Feng wrote: > Signed-off-by: Chen Feng > Signed-off-by: Yu Dongbin I can't take a patch with no changelog entry at all, sorry. You are going to have to at least explain what this driver is, what it does, and what hardware it supports. thanks, --

[PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-08 Thread Chen Feng
Signed-off-by: Chen Feng Signed-off-by: Yu Dongbin --- drivers/staging/android/ion/Kconfig| 7 + drivers/staging/android/ion/Makefile | 1 + drivers/staging/android/ion/hisilicon/Kconfig | 5 + drivers/staging/android/ion/hisilicon/Makefile | 1 +

[PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-08 Thread Chen Feng
Signed-off-by: Chen Feng Signed-off-by: Yu Dongbin --- drivers/staging/android/ion/Kconfig| 7 + drivers/staging/android/ion/Makefile | 1 + drivers/staging/android/ion/hisilicon/Kconfig | 5 +

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-08 Thread Greg KH
On Thu, Oct 08, 2015 at 03:55:12PM +0800, Chen Feng wrote: > Signed-off-by: Chen Feng > Signed-off-by: Yu Dongbin I can't take a patch with no changelog entry at all, sorry. You are going to have to at least explain what this driver is, what it

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-08 Thread kbuild test robot
Hi Chen, [auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore] config: arm-allyesconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x