On 2015/10/9 16:58, Dan Carpenter wrote:
> On Fri, Oct 09, 2015 at 11:53:32AM +0300, Dan Carpenter wrote:
>>> +out:
>>
>> Labels named "out" are bug prone because handling everything is harder
>> than using named labels and unwinding one step at a time. The bug here
>> is that we don't call
On 2015/10/9 16:58, Dan Carpenter wrote:
> On Fri, Oct 09, 2015 at 11:53:32AM +0300, Dan Carpenter wrote:
>>> +out:
>>
>> Labels named "out" are bug prone because handling everything is harder
>> than using named labels and unwinding one step at a time. The bug here
>> is that we don't call
On 2015/10/8 15:55, Chen Feng wrote:
Signed-off-by: Chen Feng
Signed-off-by: Yu Dongbin
---
drivers/staging/android/ion/Kconfig| 7 +
drivers/staging/android/ion/Makefile | 1 +
drivers/staging/android/ion/hisilicon/Kconfig | 5 +
On Fri, Oct 09, 2015 at 11:53:32AM +0300, Dan Carpenter wrote:
> > +out:
>
> Labels named "out" are bug prone because handling everything is harder
> than using named labels and unwinding one step at a time. The bug here
> is that we don't call ion_device_destroy().
>
> > + for (i = 0; i <
On Thu, Oct 08, 2015 at 03:55:12PM +0800, Chen Feng wrote:
> Signed-off-by: Chen Feng
> Signed-off-by: Yu Dongbin
> ---
> drivers/staging/android/ion/Kconfig| 7 +
> drivers/staging/android/ion/Makefile | 1 +
> drivers/staging/android/ion/hisilicon/Kconfig
On Fri, Oct 09, 2015 at 11:53:32AM +0300, Dan Carpenter wrote:
> > +out:
>
> Labels named "out" are bug prone because handling everything is harder
> than using named labels and unwinding one step at a time. The bug here
> is that we don't call ion_device_destroy().
>
> > + for (i = 0; i <
On 2015/10/8 15:55, Chen Feng wrote:
Signed-off-by: Chen Feng
Signed-off-by: Yu Dongbin
---
drivers/staging/android/ion/Kconfig| 7 +
drivers/staging/android/ion/Makefile | 1 +
On Thu, Oct 08, 2015 at 03:55:12PM +0800, Chen Feng wrote:
> Signed-off-by: Chen Feng
> Signed-off-by: Yu Dongbin
> ---
> drivers/staging/android/ion/Kconfig| 7 +
> drivers/staging/android/ion/Makefile | 1 +
>
Hi Chen,
[auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please
ignore]
config: arm-allyesconfig (attached as .config)
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +x
On Thu, Oct 08, 2015 at 03:55:12PM +0800, Chen Feng wrote:
> Signed-off-by: Chen Feng
> Signed-off-by: Yu Dongbin
I can't take a patch with no changelog entry at all, sorry. You are
going to have to at least explain what this driver is, what it does, and
what hardware it supports.
thanks,
--
Signed-off-by: Chen Feng
Signed-off-by: Yu Dongbin
---
drivers/staging/android/ion/Kconfig| 7 +
drivers/staging/android/ion/Makefile | 1 +
drivers/staging/android/ion/hisilicon/Kconfig | 5 +
drivers/staging/android/ion/hisilicon/Makefile | 1 +
Signed-off-by: Chen Feng
Signed-off-by: Yu Dongbin
---
drivers/staging/android/ion/Kconfig| 7 +
drivers/staging/android/ion/Makefile | 1 +
drivers/staging/android/ion/hisilicon/Kconfig | 5 +
On Thu, Oct 08, 2015 at 03:55:12PM +0800, Chen Feng wrote:
> Signed-off-by: Chen Feng
> Signed-off-by: Yu Dongbin
I can't take a patch with no changelog entry at all, sorry. You are
going to have to at least explain what this driver is, what it
Hi Chen,
[auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please
ignore]
config: arm-allyesconfig (attached as .config)
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +x
14 matches
Mail list logo