Re: [PATCH 2/3] uprobes/x86: Kill the "autask" arg of riprel_pre_xol()

2014-04-30 Thread Jim Keniston
On Mon, 2014-04-28 at 12:05 +0530, Srikar Dronamraju wrote: > * Oleg Nesterov [2014-04-27 18:52:27]: > > > default_pre_xol_op() passes >utask->autask to riprel_pre_xol() > > and this is just ugly because it still needs to load current->utask to > > read ->vaddr. > > > > Remove this argument,

Re: [PATCH 2/3] uprobes/x86: Kill the autask arg of riprel_pre_xol()

2014-04-30 Thread Jim Keniston
On Mon, 2014-04-28 at 12:05 +0530, Srikar Dronamraju wrote: * Oleg Nesterov o...@redhat.com [2014-04-27 18:52:27]: default_pre_xol_op() passes current-utask-autask to riprel_pre_xol() and this is just ugly because it still needs to load current-utask to read -vaddr. Remove this

Re: [PATCH 2/3] uprobes/x86: Kill the "autask" arg of riprel_pre_xol()

2014-04-28 Thread Srikar Dronamraju
* Oleg Nesterov [2014-04-27 18:52:27]: > default_pre_xol_op() passes >utask->autask to riprel_pre_xol() > and this is just ugly because it still needs to load current->utask to > read ->vaddr. > > Remove this argument, change riprel_pre_xol() to use current->utask. > > Signed-off-by: Oleg

Re: [PATCH 2/3] uprobes/x86: Kill the autask arg of riprel_pre_xol()

2014-04-28 Thread Srikar Dronamraju
* Oleg Nesterov o...@redhat.com [2014-04-27 18:52:27]: default_pre_xol_op() passes current-utask-autask to riprel_pre_xol() and this is just ugly because it still needs to load current-utask to read -vaddr. Remove this argument, change riprel_pre_xol() to use current-utask.

[PATCH 2/3] uprobes/x86: Kill the "autask" arg of riprel_pre_xol()

2014-04-27 Thread Oleg Nesterov
default_pre_xol_op() passes >utask->autask to riprel_pre_xol() and this is just ugly because it still needs to load current->utask to read ->vaddr. Remove this argument, change riprel_pre_xol() to use current->utask. Signed-off-by: Oleg Nesterov --- arch/x86/kernel/uprobes.c | 18

[PATCH 2/3] uprobes/x86: Kill the autask arg of riprel_pre_xol()

2014-04-27 Thread Oleg Nesterov
default_pre_xol_op() passes current-utask-autask to riprel_pre_xol() and this is just ugly because it still needs to load current-utask to read -vaddr. Remove this argument, change riprel_pre_xol() to use current-utask. Signed-off-by: Oleg Nesterov o...@redhat.com --- arch/x86/kernel/uprobes.c