Re: [PATCH 2/3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-29 Thread Michael Grzeschik
On Fri, Nov 29, 2013 at 10:07:49AM +0800, Chris Ruehl wrote: > * init the sts flag to 0 (missed) > * set the sts flag only if not 0 > > Signed-off-by: Chris Ruehl > --- > drivers/usb/chipidea/core.c |8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 2/3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-29 Thread Michael Grzeschik
On Fri, Nov 29, 2013 at 10:07:49AM +0800, Chris Ruehl wrote: * init the sts flag to 0 (missed) * set the sts flag only if not 0 Signed-off-by: Chris Ruehl chris.ru...@gtsys.com.hk --- drivers/usb/chipidea/core.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff

RE: [PATCH 2/3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-28 Thread Peter Chen
> > On Friday, November 29, 2013 11:27 AM, Peter Chen wrote: > > > >> * init the sts flag to 0 (missed) > >> * set the sts flag only if not 0 > >> > > does PORTSC_STS bit as 1 or 0 affect your case? > > If not, please remove hw_write(ci, OP_DEVLC, DEVLC_STS, sts), > > since it is useless at

Re: [PATCH 2/3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-28 Thread Chris Ruehl
On Friday, November 29, 2013 11:27 AM, Peter Chen wrote: * init the sts flag to 0 (missed) * set the sts flag only if not 0 does PORTSC_STS bit as 1 or 0 affect your case? If not, please remove hw_write(ci, OP_DEVLC, DEVLC_STS, sts), since it is useless at current code logic. Peter

RE: [PATCH 2/3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-28 Thread Peter Chen
> > * init the sts flag to 0 (missed) > * set the sts flag only if not 0 > does PORTSC_STS bit as 1 or 0 affect your case? If not, please remove hw_write(ci, OP_DEVLC, DEVLC_STS, sts), since it is useless at current code logic. Peter > Signed-off-by: Chris Ruehl > --- >

[PATCH 2/3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-28 Thread Chris Ruehl
* init the sts flag to 0 (missed) * set the sts flag only if not 0 Signed-off-by: Chris Ruehl --- drivers/usb/chipidea/core.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 5075407..1a6010e 100644

[PATCH 2/3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-28 Thread Chris Ruehl
* init the sts flag to 0 (missed) * set the sts flag only if not 0 Signed-off-by: Chris Ruehl chris.ru...@gtsys.com.hk --- drivers/usb/chipidea/core.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index

RE: [PATCH 2/3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-28 Thread Peter Chen
* init the sts flag to 0 (missed) * set the sts flag only if not 0 does PORTSC_STS bit as 1 or 0 affect your case? If not, please remove hw_write(ci, OP_DEVLC, DEVLC_STS, sts), since it is useless at current code logic. Peter Signed-off-by: Chris Ruehl chris.ru...@gtsys.com.hk ---

Re: [PATCH 2/3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-28 Thread Chris Ruehl
On Friday, November 29, 2013 11:27 AM, Peter Chen wrote: * init the sts flag to 0 (missed) * set the sts flag only if not 0 does PORTSC_STS bit as 1 or 0 affect your case? If not, please remove hw_write(ci, OP_DEVLC, DEVLC_STS, sts), since it is useless at current code logic. Peter

RE: [PATCH 2/3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-28 Thread Peter Chen
On Friday, November 29, 2013 11:27 AM, Peter Chen wrote: * init the sts flag to 0 (missed) * set the sts flag only if not 0 does PORTSC_STS bit as 1 or 0 affect your case? If not, please remove hw_write(ci, OP_DEVLC, DEVLC_STS, sts), since it is useless at current code logic.