RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms

2019-01-17 Thread Ran Wang
Hi Greg, On 08, 2019 23:45, Greg Kroah-Hartman wrote: > > On Tue, Jan 08, 2019 at 06:04:26AM +, Ran Wang wrote: > > arm/arm64's io.h doesn't define clrbits32() and clrsetbits_be32(), > > which causing compile failure on some Layerscape Platforms (such as > > LS1021A and LS2012A which also

RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms

2019-01-11 Thread Ran Wang
: Ran Wang > > > Cc: Greg Kroah-Hartman ; linux- > > > u...@vger.kernel.org; linux-kernel@vger.kernel.org > > > Subject: RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing > > > for > > > arm/arm64 platforms > > > > > > On Wed, 9 Jan 2019

RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms

2019-01-10 Thread Alan Stern
org > > Subject: RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for > > arm/arm64 platforms > > > > On Wed, 9 Jan 2019, Ran Wang wrote: > > > > > > Why do you change this writel() into iowrite32be() but leave other > > > > instan

RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms

2019-01-09 Thread Ran Wang
Hi Alan, > -Original Message- > From: Alan Stern > Sent: Wednesday, January 09, 2019 23:14 > To: Ran Wang > Cc: Greg Kroah-Hartman ; linux- > u...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for

RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms

2019-01-09 Thread Alan Stern
On Wed, 9 Jan 2019, Ran Wang wrote: > > Why do you change this writel() into iowrite32be() but leave other instances > > of writel() unchanged? Was this a mistake? > > Yes, I didn't notice there are other writel() used in this file. > However, as I know, on both powerpc and arm SoC, EHCI FSL

RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms

2019-01-08 Thread Ran Wang
Hi Alan, > -Original Message- > From: Alan Stern > Sent: Wednesday, January 09, 2019 00:20 > To: Ran Wang > Cc: Greg Kroah-Hartman ; linux- > u...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 2/3] usb: ehci: fsl: Update register accessing for

Re: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms

2019-01-08 Thread Alan Stern
On Tue, 8 Jan 2019, Ran Wang wrote: > arm/arm64's io.h doesn't define clrbits32() and clrsetbits_be32(), which > causing compile failure on some Layerscape Platforms (such as LS1021A and > LS2012A which also integrates FSL EHCI controller). So use > ioread32be()/iowrite32be() instead to make it

Re: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms

2019-01-08 Thread Greg Kroah-Hartman
On Tue, Jan 08, 2019 at 06:04:26AM +, Ran Wang wrote: > arm/arm64's io.h doesn't define clrbits32() and clrsetbits_be32(), which > causing compile failure on some Layerscape Platforms (such as LS1021A and > LS2012A which also integrates FSL EHCI controller). So use > ioread32be()/iowrite32be()

[PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms

2019-01-07 Thread Ran Wang
arm/arm64's io.h doesn't define clrbits32() and clrsetbits_be32(), which causing compile failure on some Layerscape Platforms (such as LS1021A and LS2012A which also integrates FSL EHCI controller). So use ioread32be()/iowrite32be() instead to make it workable on both powerpc and arm.