Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-24 Thread Connor Kuehl
On 3/24/21 10:30 AM, Miklos Szeredi wrote: On Wed, Mar 24, 2021 at 4:09 PM Connor Kuehl wrote: On 3/18/21 10:17 AM, Miklos Szeredi wrote: I removed the conditional compilation and renamed the limit. Also made virtio_fs_get_tree() bail out if it hit the WARN_ON(). Updated patch below. Hi

Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-24 Thread Miklos Szeredi
On Wed, Mar 24, 2021 at 4:09 PM Connor Kuehl wrote: > > On 3/18/21 10:17 AM, Miklos Szeredi wrote: > > I removed the conditional compilation and renamed the limit. Also made > > virtio_fs_get_tree() bail out if it hit the WARN_ON(). Updated patch below. > > Hi Miklos, > > Has this patch been

Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-24 Thread Connor Kuehl
On 3/18/21 10:17 AM, Miklos Szeredi wrote: I removed the conditional compilation and renamed the limit. Also made virtio_fs_get_tree() bail out if it hit the WARN_ON(). Updated patch below. Hi Miklos, Has this patch been queued? Connor --- From: Connor Kuehl Subject: virtiofs: split

Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-22 Thread Vivek Goyal
On Thu, Mar 18, 2021 at 04:17:51PM +0100, Miklos Szeredi wrote: > On Thu, Mar 18, 2021 at 08:52:22AM -0500, Connor Kuehl wrote: > > If an incoming FUSE request can't fit on the virtqueue, the request is > > placed onto a workqueue so a worker can try to resubmit it later where > > there will

Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-22 Thread Stefan Hajnoczi
On Thu, Mar 18, 2021 at 08:52:22AM -0500, Connor Kuehl wrote: > If an incoming FUSE request can't fit on the virtqueue, the request is > placed onto a workqueue so a worker can try to resubmit it later where > there will (hopefully) be space for it next time. > > This is fine for requests that

Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-20 Thread Michael S. Tsirkin
On Thu, Mar 18, 2021 at 10:52:14AM -0500, Connor Kuehl wrote: > On 3/18/21 10:17 AM, Miklos Szeredi wrote: > > I removed the conditional compilation and renamed the limit. Also made > > virtio_fs_get_tree() bail out if it hit the WARN_ON(). Updated patch below. > > Thanks, Miklos. I think it

Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-19 Thread Connor Kuehl
On 3/19/21 8:49 AM, Vivek Goyal wrote: On Thu, Mar 18, 2021 at 08:52:22AM -0500, Connor Kuehl wrote: If an incoming FUSE request can't fit on the virtqueue, the request is placed onto a workqueue so a worker can try to resubmit it later where there will (hopefully) be space for it next time.

Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-19 Thread Vivek Goyal
On Thu, Mar 18, 2021 at 08:52:22AM -0500, Connor Kuehl wrote: > If an incoming FUSE request can't fit on the virtqueue, the request is > placed onto a workqueue so a worker can try to resubmit it later where > there will (hopefully) be space for it next time. > > This is fine for requests that

Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-18 Thread Connor Kuehl
On 3/18/21 10:17 AM, Miklos Szeredi wrote: I removed the conditional compilation and renamed the limit. Also made virtio_fs_get_tree() bail out if it hit the WARN_ON(). Updated patch below. Thanks, Miklos. I think it looks better with those changes. The virtio_ring patch in this series

Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-18 Thread Miklos Szeredi
On Thu, Mar 18, 2021 at 08:52:22AM -0500, Connor Kuehl wrote: > If an incoming FUSE request can't fit on the virtqueue, the request is > placed onto a workqueue so a worker can try to resubmit it later where > there will (hopefully) be space for it next time. > > This is fine for requests that

[PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-18 Thread Connor Kuehl
If an incoming FUSE request can't fit on the virtqueue, the request is placed onto a workqueue so a worker can try to resubmit it later where there will (hopefully) be space for it next time. This is fine for requests that aren't larger than a virtqueue's maximum capacity. However, if a request's