Re: [PATCH 2/3] workqueue: trivial fix for return statement in work_busy()

2012-10-20 Thread Tejun Heo
On Sun, Oct 21, 2012 at 01:30:06AM +0900, Joonsoo Kim wrote: > Return type of work_busy() is unsigned int. > There is return statement returning boolean value, 'false' in work_busy(). > It is not problem, because 'false' may be treated '0'. > However, fixing it would make code robust. > >

[PATCH 2/3] workqueue: trivial fix for return statement in work_busy()

2012-10-20 Thread Joonsoo Kim
Return type of work_busy() is unsigned int. There is return statement returning boolean value, 'false' in work_busy(). It is not problem, because 'false' may be treated '0'. However, fixing it would make code robust. Signed-off-by: Joonsoo Kim diff --git a/kernel/workqueue.c

[PATCH 2/3] workqueue: trivial fix for return statement in work_busy()

2012-10-20 Thread Joonsoo Kim
Return type of work_busy() is unsigned int. There is return statement returning boolean value, 'false' in work_busy(). It is not problem, because 'false' may be treated '0'. However, fixing it would make code robust. Signed-off-by: Joonsoo Kim js1...@gmail.com diff --git a/kernel/workqueue.c

Re: [PATCH 2/3] workqueue: trivial fix for return statement in work_busy()

2012-10-20 Thread Tejun Heo
On Sun, Oct 21, 2012 at 01:30:06AM +0900, Joonsoo Kim wrote: Return type of work_busy() is unsigned int. There is return statement returning boolean value, 'false' in work_busy(). It is not problem, because 'false' may be treated '0'. However, fixing it would make code robust.