Re: [PATCH 2/3] writeback: fix incorrect return value type of bdi_dirty_limit

2012-08-19 Thread Namjae Jeon
2012/8/19, Fengguang Wu : > On Sat, Aug 18, 2012 at 05:49:21AM -0400, Namjae Jeon wrote: >> unsigned long bdi_dirty_limit(struct backing_dev_info *bdi, unsigned long >> dirty) >> >> Above function return type is unsigned long, but return value is >> kept in "u64 bdi_dirty". >> It can return incorre

Re: [PATCH 2/3] writeback: fix incorrect return value type of bdi_dirty_limit

2012-08-19 Thread Namjae Jeon
2012/8/19, Marco Stornelli : > Il 19/08/2012 04:17, Fengguang Wu ha scritto: >> On Sat, Aug 18, 2012 at 05:49:21AM -0400, Namjae Jeon wrote: >>> unsigned long bdi_dirty_limit(struct backing_dev_info *bdi, unsigned long >>> dirty) >>> >>> Above function return type is unsigned long, but return value

Re: [PATCH 2/3] writeback: fix incorrect return value type of bdi_dirty_limit

2012-08-19 Thread Marco Stornelli
Il 19/08/2012 12:23, Marco Stornelli ha scritto: Il 19/08/2012 04:17, Fengguang Wu ha scritto: On Sat, Aug 18, 2012 at 05:49:21AM -0400, Namjae Jeon wrote: unsigned long bdi_dirty_limit(struct backing_dev_info *bdi, unsigned long dirty) Above function return type is unsigned long, but return v

Re: [PATCH 2/3] writeback: fix incorrect return value type of bdi_dirty_limit

2012-08-19 Thread Marco Stornelli
Il 19/08/2012 04:17, Fengguang Wu ha scritto: On Sat, Aug 18, 2012 at 05:49:21AM -0400, Namjae Jeon wrote: unsigned long bdi_dirty_limit(struct backing_dev_info *bdi, unsigned long dirty) Above function return type is unsigned long, but return value is kept in "u64 bdi_dirty". It can return inc

Re: [PATCH 2/3] writeback: fix incorrect return value type of bdi_dirty_limit

2012-08-18 Thread Fengguang Wu
On Sat, Aug 18, 2012 at 05:49:21AM -0400, Namjae Jeon wrote: > unsigned long bdi_dirty_limit(struct backing_dev_info *bdi, unsigned long > dirty) > > Above function return type is unsigned long, but return value is > kept in "u64 bdi_dirty". > It can return incorrect value by type casting. I don

[PATCH 2/3] writeback: fix incorrect return value type of bdi_dirty_limit

2012-08-18 Thread Namjae Jeon
unsigned long bdi_dirty_limit(struct backing_dev_info *bdi, unsigned long dirty) Above function return type is unsigned long, but return value is kept in "u64 bdi_dirty". It can return incorrect value by type casting. Signed-off-by: Namjae Jeon --- mm/page-writeback.c |2 +- 1 file changed,