Re: [PATCH 2/3] x86/entry: Fix entry/exit mismatch on failed fast 32-bit syscalls

2021-02-23 Thread Andy Lutomirski
> On Feb 23, 2021, at 3:29 AM, Peter Zijlstra wrote: > > On Mon, Feb 22, 2021 at 09:50:28PM -0800, Andy Lutomirski wrote: >> On a 32-bit fast syscall that fails to read its arguments from user >> memory, the kernel currently does syscall exit work but not >> syscall exit work. This would

Re: [PATCH 2/3] x86/entry: Fix entry/exit mismatch on failed fast 32-bit syscalls

2021-02-23 Thread Peter Zijlstra
On Mon, Feb 22, 2021 at 09:50:28PM -0800, Andy Lutomirski wrote: > On a 32-bit fast syscall that fails to read its arguments from user > memory, the kernel currently does syscall exit work but not > syscall exit work. This would confuse audit and ptrace. > > This is a minimal fix intended for

Re: [PATCH 2/3] x86/entry: Fix entry/exit mismatch on failed fast 32-bit syscalls

2021-02-23 Thread Thomas Gleixner
On Mon, Feb 22 2021 at 21:50, Andy Lutomirski wrote: > On a 32-bit fast syscall that fails to read its arguments from user > memory, the kernel currently does syscall exit work but not > syscall exit work. and this sentence does not make any sense. > This would confuse audit and ptrace. Would?

[PATCH 2/3] x86/entry: Fix entry/exit mismatch on failed fast 32-bit syscalls

2021-02-22 Thread Andy Lutomirski
On a 32-bit fast syscall that fails to read its arguments from user memory, the kernel currently does syscall exit work but not syscall exit work. This would confuse audit and ptrace. This is a minimal fix intended for ease of backporting. A more complete cleanup is coming. Cc: