Re: [PATCH 2/3] x86: apuv2: fix input dependencies

2019-03-06 Thread Darren Hart
On Thu, Mar 07, 2019 at 01:10:13AM +0100, Enrico Weigelt, metux IT consult wrote: > On 05.03.19 14:56, Andy Shevchenko wrote: > > > > Darren gave a talk about merging kernel configs to get something like > > you want to. > > This tool is quite long already lying around. merge_config.sh in your >

Re: [PATCH 2/3] x86: apuv2: fix input dependencies

2019-03-06 Thread Enrico Weigelt, metux IT consult
On 05.03.19 14:56, Andy Shevchenko wrote: > > Darren gave a talk about merging kernel configs to get something like > you want to. > This tool is quite long already lying around. merge_config.sh in your > kernel source tree. Yes, that's similar to how some distros (eg. yocto) do it. But my

Re: [PATCH 2/3] x86: apuv2: fix input dependencies

2019-03-05 Thread Arnd Bergmann
On Tue, Mar 5, 2019 at 2:50 PM Enrico Weigelt, metux IT consult wrote: > > On 05.03.19 09:23, Arnd Bergmann wrote: > > hmm, if circular deps happen, wouldn't that mean we've got some deeper > problems in here ? IMHO, dependencies should always form a DAG (except > for some really rare cases). > >

Re: [PATCH 2/3] x86: apuv2: fix input dependencies

2019-03-05 Thread Andy Shevchenko
On Tue, Mar 5, 2019 at 3:50 PM Enrico Weigelt, metux IT consult wrote: > On 05.03.19 09:23, Arnd Bergmann wrote: > > 1. try to use 'depends on' if you can > > Well, this has the unpleasant side effect that we often have to enable > a lot of things, just to even see the individual driver. For

Re: [PATCH 2/3] x86: apuv2: fix input dependencies

2019-03-05 Thread Enrico Weigelt, metux IT consult
On 05.03.19 09:23, Arnd Bergmann wrote: (CC'ing kbuild maintainer + list, hoping for better ideas :) > No, that wouldn't be good here. In effect that means that with INPUT disabled, > most of the x86 platform drivers are disabled, until you enable the > PCENGINES_APU2 symbol, which then ends up

Re: [PATCH 2/3] x86: apuv2: fix input dependencies

2019-03-05 Thread Arnd Bergmann
On Tue, Mar 5, 2019 at 1:18 AM Enrico Weigelt, metux IT consult wrote: > > On 04.03.19 21:19, Arnd Bergmann wrote: > > > This could be fixed using either a dependency or a 'select' statement. > > I'm chosen 'depends on' here since it is simpler has a lower risk of > > introducing circular

Re: [PATCH 2/3] x86: apuv2: fix input dependencies

2019-03-04 Thread Enrico Weigelt, metux IT consult
On 04.03.19 21:19, Arnd Bergmann wrote: > This could be fixed using either a dependency or a 'select' statement. > I'm chosen 'depends on' here since it is simpler has a lower risk of > introducing circular dependencies. I'd rather prefer using 'select'. Otherwise the driver won't appear at all

[PATCH 2/3] x86: apuv2: fix input dependencies

2019-03-04 Thread Arnd Bergmann
We cannot select KEYBOARD_GPIO_POLLED if CONFIG_INPUT or CONFIG_INPUT_KEYBOARD are disabled: WARNING: unmet direct dependencies detected for KEYBOARD_GPIO_POLLED Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n] && GPIOLIB [=y] Selected by [y]: - PCENGINES_APU2 [=y] && X86 [=y] &&