Re: [PATCH 2/4] Makefile: clang: choose GCC_TOOLCHAIN_DIR not on LD

2019-02-07 Thread Nathan Chancellor
On Thu, Feb 07, 2019 at 02:01:50PM -0800, ndesaulni...@google.com wrote: > This causes an issue when trying to build with `make LD=ld.lld` if > ld.lld and the rest of your cross tools aren't in the same directory > (ex. /usr/local/bin) (as is the case for Android's build system), as the > GCC_TOOLC

[PATCH 2/4] Makefile: clang: choose GCC_TOOLCHAIN_DIR not on LD

2019-02-07 Thread ndesaulniers
This causes an issue when trying to build with `make LD=ld.lld` if ld.lld and the rest of your cross tools aren't in the same directory (ex. /usr/local/bin) (as is the case for Android's build system), as the GCC_TOOLCHAIN_DIR then gets set based on `which $(LD)` which will point where LLVM tools a