Re: [PATCH 2/4] PCI: add functionality for resizing resources v2

2017-04-12 Thread Bjorn Helgaas
On Tue, Apr 11, 2017 at 05:37:04PM +0200, Christian König wrote: > >>+int pci_resize_resource(struct pci_dev *dev, int resno, int size) > >>+{ > >>+ struct resource *res = dev->resource + resno; > >>+ u32 sizes = pci_rbar_get_possible_sizes(dev, resno); > >>+ int old =

Re: [PATCH 2/4] PCI: add functionality for resizing resources v2

2017-04-12 Thread Bjorn Helgaas
On Tue, Apr 11, 2017 at 05:37:04PM +0200, Christian König wrote: > >>+int pci_resize_resource(struct pci_dev *dev, int resno, int size) > >>+{ > >>+ struct resource *res = dev->resource + resno; > >>+ u32 sizes = pci_rbar_get_possible_sizes(dev, resno); > >>+ int old =

Re: [PATCH 2/4] PCI: add functionality for resizing resources v2

2017-04-11 Thread Christian König
Hi Bjorn, first of all sorry for the delay, had been busy with other stuff in the last few weeks. Am 24.03.2017 um 22:34 schrieb Bjorn Helgaas: + release_child_resources(res); Doesn't this recursively release *all* child resources? There could be BARs from several

Re: [PATCH 2/4] PCI: add functionality for resizing resources v2

2017-04-11 Thread Christian König
Hi Bjorn, first of all sorry for the delay, had been busy with other stuff in the last few weeks. Am 24.03.2017 um 22:34 schrieb Bjorn Helgaas: + release_child_resources(res); Doesn't this recursively release *all* child resources? There could be BARs from several

Re: [PATCH 2/4] PCI: add functionality for resizing resources v2

2017-04-11 Thread Christian König
Sorry for the delayed response, have been busy with other stuff recently. Am 13.03.2017 um 17:43 schrieb Andy Shevchenko: v2: rebase on changes in rbar support This kind of comments usually goes after --- delimiter below. That would remove it from the commit message which I don't want. +

Re: [PATCH 2/4] PCI: add functionality for resizing resources v2

2017-04-11 Thread Christian König
Sorry for the delayed response, have been busy with other stuff recently. Am 13.03.2017 um 17:43 schrieb Andy Shevchenko: v2: rebase on changes in rbar support This kind of comments usually goes after --- delimiter below. That would remove it from the commit message which I don't want. +

Re: [PATCH 2/4] PCI: add functionality for resizing resources v2

2017-03-24 Thread Bjorn Helgaas
On Mon, Mar 13, 2017 at 01:41:34PM +0100, Christian König wrote: > From: Christian König > > This allows device drivers to request resizing their BARs. > > The function only tries to reprogram the windows of the bridge directly above > the requesting device and only

Re: [PATCH 2/4] PCI: add functionality for resizing resources v2

2017-03-24 Thread Bjorn Helgaas
On Mon, Mar 13, 2017 at 01:41:34PM +0100, Christian König wrote: > From: Christian König > > This allows device drivers to request resizing their BARs. > > The function only tries to reprogram the windows of the bridge directly above > the requesting device and only the BAR of the same type

Re: [PATCH 2/4] PCI: add functionality for resizing resources v2

2017-03-14 Thread kbuild test robot
Hi Christian, [auto build test WARNING on pci/next] [also build test WARNING on v4.11-rc2 next-20170310] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/4] PCI: add functionality for resizing resources v2

2017-03-14 Thread kbuild test robot
Hi Christian, [auto build test WARNING on pci/next] [also build test WARNING on v4.11-rc2 next-20170310] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/4] PCI: add functionality for resizing resources v2

2017-03-13 Thread Andy Shevchenko
On Mon, Mar 13, 2017 at 2:41 PM, Christian König wrote: > From: Christian König > > This allows device drivers to request resizing their BARs. > > The function only tries to reprogram the windows of the bridge directly above > the requesting

Re: [PATCH 2/4] PCI: add functionality for resizing resources v2

2017-03-13 Thread Andy Shevchenko
On Mon, Mar 13, 2017 at 2:41 PM, Christian König wrote: > From: Christian König > > This allows device drivers to request resizing their BARs. > > The function only tries to reprogram the windows of the bridge directly above > the requesting device and only the BAR of the same type (usually mem,

[PATCH 2/4] PCI: add functionality for resizing resources v2

2017-03-13 Thread Christian König
From: Christian König This allows device drivers to request resizing their BARs. The function only tries to reprogram the windows of the bridge directly above the requesting device and only the BAR of the same type (usually mem, 64bit, prefetchable). This is done to

[PATCH 2/4] PCI: add functionality for resizing resources v2

2017-03-13 Thread Christian König
From: Christian König This allows device drivers to request resizing their BARs. The function only tries to reprogram the windows of the bridge directly above the requesting device and only the BAR of the same type (usually mem, 64bit, prefetchable). This is done to make sure not to disturb