Re: [PATCH 2/4] Revert "lib/string.c: implement a basic bcmp"

2020-08-18 Thread Kees Cook
On Tue, Aug 18, 2020 at 11:00:01AM -0700, Nick Desaulniers wrote: > On Mon, Aug 17, 2020 at 10:44 PM Nathan Chancellor > wrote: > > > > On Mon, Aug 17, 2020 at 03:02:10PM -0700, Nick Desaulniers wrote: > > > This reverts commit 5f074f3e192f10c9fade898b9b3b8812e3d83342. > > > > > > Use

Re: [PATCH 2/4] Revert "lib/string.c: implement a basic bcmp"

2020-08-18 Thread Nick Desaulniers
On Mon, Aug 17, 2020 at 10:44 PM Nathan Chancellor wrote: > > On Mon, Aug 17, 2020 at 03:02:10PM -0700, Nick Desaulniers wrote: > > This reverts commit 5f074f3e192f10c9fade898b9b3b8812e3d83342. > > > > Use `-fno-builtin-bcmp` instead. > > > > The issue with using `-fno-builtin-*` flags was that

Re: [PATCH 2/4] Revert "lib/string.c: implement a basic bcmp"

2020-08-17 Thread Nathan Chancellor
On Mon, Aug 17, 2020 at 03:02:10PM -0700, Nick Desaulniers wrote: > This reverts commit 5f074f3e192f10c9fade898b9b3b8812e3d83342. > > Use `-fno-builtin-bcmp` instead. > > The issue with using `-fno-builtin-*` flags was that they were not > retained during an LTO link with LLVM. This was fixed

[PATCH 2/4] Revert "lib/string.c: implement a basic bcmp"

2020-08-17 Thread Nick Desaulniers
This reverts commit 5f074f3e192f10c9fade898b9b3b8812e3d83342. Use `-fno-builtin-bcmp` instead. The issue with using `-fno-builtin-*` flags was that they were not retained during an LTO link with LLVM. This was fixed in clang-11 by https://reviews.llvm.org/D71193