Rename old vfs_ioctl to do_ioctl, because the comment above it clearly
indicates that it is an internal function not to be exported to modules;
therefore it should have a more traditional do_XXX name. The new do_ioctl
is exported in fs.h but not to modules.
Rename the old do_ioctl to vfs_ioctl
In message <[EMAIL PROTECTED]>, Christoph Hellwig writes:
> On Tue, Oct 30, 2007 at 08:22:40AM -0700, Randy Dunlap wrote:
> > They are just treated as part of the parameter explanation text.
> > I don't see any problem with them.
>
> Well, it's completely inconsistant with any other kerneldoc..
On Tue, 30 Oct 2007 17:14:36 + Christoph Hellwig wrote:
> On Tue, Oct 30, 2007 at 08:22:40AM -0700, Randy Dunlap wrote:
> > They are just treated as part of the parameter explanation text.
> > I don't see any problem with them.
>
> Well, it's completely inconsistant with any other
On Tue, Oct 30, 2007 at 08:22:40AM -0700, Randy Dunlap wrote:
> They are just treated as part of the parameter explanation text.
> I don't see any problem with them.
Well, it's completely inconsistant with any other kerneldoc..
-
To unsubscribe from this list: send the line "unsubscribe
On Tue, 30 Oct 2007 09:56:53 + Christoph Hellwig wrote:
> On Sun, Oct 28, 2007 at 08:40:56PM -0400, Erez Zadok wrote:
> > +/**
> > + * vfs_ioctl - call filesystem specific ioctl methods
> > + *
> > + * @filp: [in] open file to invoke ioctl method on
> > + * @cmd: [in] ioctl command
On Sun, Oct 28, 2007 at 08:40:56PM -0400, Erez Zadok wrote:
> +/**
> + * vfs_ioctl - call filesystem specific ioctl methods
> + *
> + * @filp: [in] open file to invoke ioctl method on
> + * @cmd: [in] ioctl command to execute
> + * @arg: [in/out] command-specific argument for ioctl
I've
On Sun, Oct 28, 2007 at 08:40:56PM -0400, Erez Zadok wrote:
+/**
+ * vfs_ioctl - call filesystem specific ioctl methods
+ *
+ * @filp: [in] open file to invoke ioctl method on
+ * @cmd: [in] ioctl command to execute
+ * @arg: [in/out] command-specific argument for ioctl
I've never
On Tue, 30 Oct 2007 09:56:53 + Christoph Hellwig wrote:
On Sun, Oct 28, 2007 at 08:40:56PM -0400, Erez Zadok wrote:
+/**
+ * vfs_ioctl - call filesystem specific ioctl methods
+ *
+ * @filp: [in] open file to invoke ioctl method on
+ * @cmd: [in] ioctl command to execute
On Tue, Oct 30, 2007 at 08:22:40AM -0700, Randy Dunlap wrote:
They are just treated as part of the parameter explanation text.
I don't see any problem with them.
Well, it's completely inconsistant with any other kerneldoc..
-
To unsubscribe from this list: send the line unsubscribe
On Tue, 30 Oct 2007 17:14:36 + Christoph Hellwig wrote:
On Tue, Oct 30, 2007 at 08:22:40AM -0700, Randy Dunlap wrote:
They are just treated as part of the parameter explanation text.
I don't see any problem with them.
Well, it's completely inconsistant with any other kerneldoc..
In message [EMAIL PROTECTED], Christoph Hellwig writes:
On Tue, Oct 30, 2007 at 08:22:40AM -0700, Randy Dunlap wrote:
They are just treated as part of the parameter explanation text.
I don't see any problem with them.
Well, it's completely inconsistant with any other kerneldoc..
If it
Rename old vfs_ioctl to do_ioctl, because the comment above it clearly
indicates that it is an internal function not to be exported to modules;
therefore it should have a more traditional do_XXX name. The new do_ioctl
is exported in fs.h but not to modules.
Rename the old do_ioctl to vfs_ioctl
On Sun, 28 Oct 2007 20:40:56 -0400 Erez Zadok wrote:
> Rename old vfs_ioctl to do_ioctl, because the comment above it clearly
> indicates that it is an internal function not to be exported to modules;
> therefore it should have a more traditional do_XXX name. The new do_ioctl
> is exported in
Rename old vfs_ioctl to do_ioctl, because the comment above it clearly
indicates that it is an internal function not to be exported to modules;
therefore it should have a more traditional do_XXX name. The new do_ioctl
is exported in fs.h but not to modules.
Rename the old do_ioctl to vfs_ioctl
Rename old vfs_ioctl to do_ioctl, because the comment above it clearly
indicates that it is an internal function not to be exported to modules;
therefore it should have a more traditional do_XXX name. The new do_ioctl
is exported in fs.h but not to modules.
Rename the old do_ioctl to vfs_ioctl
On Sun, 28 Oct 2007 20:40:56 -0400 Erez Zadok wrote:
Rename old vfs_ioctl to do_ioctl, because the comment above it clearly
indicates that it is an internal function not to be exported to modules;
therefore it should have a more traditional do_XXX name. The new do_ioctl
is exported in fs.h
16 matches
Mail list logo
