Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-08-13 Thread Amit Nischal
On 2018-08-08 11:28, Stephen Boyd wrote: Quoting Jordan Crouse (2018-08-06 08:04:37) On Mon, Aug 06, 2018 at 02:37:18PM +0530, Amit Nischal wrote: > On 2018-08-03 04:14, Stephen Boyd wrote: > >Quoting Amit Nischal (2018-07-30 04:28:56) > >>On 2018-07-25 12:28, Stephen Boyd wrote: > >>> > >>>

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-08-13 Thread Amit Nischal
On 2018-08-08 11:28, Stephen Boyd wrote: Quoting Jordan Crouse (2018-08-06 08:04:37) On Mon, Aug 06, 2018 at 02:37:18PM +0530, Amit Nischal wrote: > On 2018-08-03 04:14, Stephen Boyd wrote: > >Quoting Amit Nischal (2018-07-30 04:28:56) > >>On 2018-07-25 12:28, Stephen Boyd wrote: > >>> > >>>

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-08-08 Thread Jordan Crouse
On Tue, Aug 07, 2018 at 10:58:19PM -0700, Stephen Boyd wrote: > Quoting Jordan Crouse (2018-08-06 08:04:37) > > On Mon, Aug 06, 2018 at 02:37:18PM +0530, Amit Nischal wrote: > > > On 2018-08-03 04:14, Stephen Boyd wrote: > > > >Quoting Amit Nischal (2018-07-30 04:28:56) > > > >>On 2018-07-25

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-08-08 Thread Jordan Crouse
On Tue, Aug 07, 2018 at 10:58:19PM -0700, Stephen Boyd wrote: > Quoting Jordan Crouse (2018-08-06 08:04:37) > > On Mon, Aug 06, 2018 at 02:37:18PM +0530, Amit Nischal wrote: > > > On 2018-08-03 04:14, Stephen Boyd wrote: > > > >Quoting Amit Nischal (2018-07-30 04:28:56) > > > >>On 2018-07-25

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-08-07 Thread Stephen Boyd
Quoting Jordan Crouse (2018-08-06 08:04:37) > On Mon, Aug 06, 2018 at 02:37:18PM +0530, Amit Nischal wrote: > > On 2018-08-03 04:14, Stephen Boyd wrote: > > >Quoting Amit Nischal (2018-07-30 04:28:56) > > >>On 2018-07-25 12:28, Stephen Boyd wrote: > > >>> > > >>> Ok. Sounds good! Is the rate range

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-08-07 Thread Stephen Boyd
Quoting Jordan Crouse (2018-08-06 08:04:37) > On Mon, Aug 06, 2018 at 02:37:18PM +0530, Amit Nischal wrote: > > On 2018-08-03 04:14, Stephen Boyd wrote: > > >Quoting Amit Nischal (2018-07-30 04:28:56) > > >>On 2018-07-25 12:28, Stephen Boyd wrote: > > >>> > > >>> Ok. Sounds good! Is the rate range

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-08-06 Thread Jordan Crouse
On Mon, Aug 06, 2018 at 02:37:18PM +0530, Amit Nischal wrote: > On 2018-08-03 04:14, Stephen Boyd wrote: > >Quoting Amit Nischal (2018-07-30 04:28:56) > >>On 2018-07-25 12:28, Stephen Boyd wrote: > >>> > >>> Ok. Sounds good! Is the rate range call really needed? It can't be > >>> determined in the

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-08-06 Thread Jordan Crouse
On Mon, Aug 06, 2018 at 02:37:18PM +0530, Amit Nischal wrote: > On 2018-08-03 04:14, Stephen Boyd wrote: > >Quoting Amit Nischal (2018-07-30 04:28:56) > >>On 2018-07-25 12:28, Stephen Boyd wrote: > >>> > >>> Ok. Sounds good! Is the rate range call really needed? It can't be > >>> determined in the

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-08-06 Thread Amit Nischal
On 2018-08-03 04:14, Stephen Boyd wrote: Quoting Amit Nischal (2018-07-30 04:28:56) On 2018-07-25 12:28, Stephen Boyd wrote: > > Ok. Sounds good! Is the rate range call really needed? It can't be > determined in the PLL code with some table or avoided by making sure > GPU > uses OPP table with

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-08-06 Thread Amit Nischal
On 2018-08-03 04:14, Stephen Boyd wrote: Quoting Amit Nischal (2018-07-30 04:28:56) On 2018-07-25 12:28, Stephen Boyd wrote: > > Ok. Sounds good! Is the rate range call really needed? It can't be > determined in the PLL code with some table or avoided by making sure > GPU > uses OPP table with

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-08-02 Thread Stephen Boyd
Quoting Amit Nischal (2018-07-30 04:28:56) > On 2018-07-25 12:28, Stephen Boyd wrote: > > > > Ok. Sounds good! Is the rate range call really needed? It can't be > > determined in the PLL code with some table or avoided by making sure > > GPU > > uses OPP table with only approved frequencies? > >

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-08-02 Thread Stephen Boyd
Quoting Amit Nischal (2018-07-30 04:28:56) > On 2018-07-25 12:28, Stephen Boyd wrote: > > > > Ok. Sounds good! Is the rate range call really needed? It can't be > > determined in the PLL code with some table or avoided by making sure > > GPU > > uses OPP table with only approved frequencies? > >

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-07-30 Thread Amit Nischal
On 2018-07-25 12:28, Stephen Boyd wrote: Quoting Amit Nischal (2018-07-12 05:30:21) On 2018-07-09 11:45, Stephen Boyd wrote: > Quoting Amit Nischal (2018-06-06 04:41:46) >> To turn on the gpu_gx_gdsc, there is a hardware requirement to >> turn on the root clock (GFX3D RCG) first which would be

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-07-30 Thread Amit Nischal
On 2018-07-25 12:28, Stephen Boyd wrote: Quoting Amit Nischal (2018-07-12 05:30:21) On 2018-07-09 11:45, Stephen Boyd wrote: > Quoting Amit Nischal (2018-06-06 04:41:46) >> To turn on the gpu_gx_gdsc, there is a hardware requirement to >> turn on the root clock (GFX3D RCG) first which would be

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-07-25 Thread Stephen Boyd
Quoting Amit Nischal (2018-07-12 05:30:21) > On 2018-07-09 11:45, Stephen Boyd wrote: > > Quoting Amit Nischal (2018-06-06 04:41:46) > >> To turn on the gpu_gx_gdsc, there is a hardware requirement to > >> turn on the root clock (GFX3D RCG) first which would be the turn > >> on signal for the gdsc

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-07-25 Thread Stephen Boyd
Quoting Amit Nischal (2018-07-12 05:30:21) > On 2018-07-09 11:45, Stephen Boyd wrote: > > Quoting Amit Nischal (2018-06-06 04:41:46) > >> To turn on the gpu_gx_gdsc, there is a hardware requirement to > >> turn on the root clock (GFX3D RCG) first which would be the turn > >> on signal for the gdsc

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-07-12 Thread Amit Nischal
On 2018-07-09 11:45, Stephen Boyd wrote: Quoting Amit Nischal (2018-06-06 04:41:46) To turn on the gpu_gx_gdsc, there is a hardware requirement to turn on the root clock (GFX3D RCG) first which would be the turn on signal for the gdsc along with the SW_COLLAPSE. As per the current

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-07-12 Thread Amit Nischal
On 2018-07-09 11:45, Stephen Boyd wrote: Quoting Amit Nischal (2018-06-06 04:41:46) To turn on the gpu_gx_gdsc, there is a hardware requirement to turn on the root clock (GFX3D RCG) first which would be the turn on signal for the gdsc along with the SW_COLLAPSE. As per the current

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-07-09 Thread Stephen Boyd
Quoting Amit Nischal (2018-06-06 04:41:46) > To turn on the gpu_gx_gdsc, there is a hardware requirement to > turn on the root clock (GFX3D RCG) first which would be the turn > on signal for the gdsc along with the SW_COLLAPSE. As per the > current implementation of clk_rcg2_shared_ops, it clears

Re: [PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-07-09 Thread Stephen Boyd
Quoting Amit Nischal (2018-06-06 04:41:46) > To turn on the gpu_gx_gdsc, there is a hardware requirement to > turn on the root clock (GFX3D RCG) first which would be the turn > on signal for the gdsc along with the SW_COLLAPSE. As per the > current implementation of clk_rcg2_shared_ops, it clears

[PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-06-06 Thread Amit Nischal
To turn on the gpu_gx_gdsc, there is a hardware requirement to turn on the root clock (GFX3D RCG) first which would be the turn on signal for the gdsc along with the SW_COLLAPSE. As per the current implementation of clk_rcg2_shared_ops, it clears the root_enable bit in the enable() and set_rate()

[PATCH 2/4] clk: qcom: Add clk_rcg2_gfx3d_ops for SDM845

2018-06-06 Thread Amit Nischal
To turn on the gpu_gx_gdsc, there is a hardware requirement to turn on the root clock (GFX3D RCG) first which would be the turn on signal for the gdsc along with the SW_COLLAPSE. As per the current implementation of clk_rcg2_shared_ops, it clears the root_enable bit in the enable() and set_rate()