Re: [PATCH 2/4] i2c: rcar: enable RuntimePM before registering to the core

2015-10-09 Thread Wolfram Sang
> You forgot to call pm_runtime_disable() in the error path. > I think some of your other patches suffer from the same issue. Ouch! Thanks a lot, Geert! signature.asc Description: Digital signature

Re: [PATCH 2/4] i2c: rcar: enable RuntimePM before registering to the core

2015-10-09 Thread Geert Uytterhoeven
Hi Wolfram, On Fri, Oct 9, 2015 at 8:54 AM, Wolfram Sang wrote: > The core may register clients attached to this master which may use > funtionality from the master. So, RuntimePM must be enabled before, otherwise > this will fail. While here, move drvdata, too. Thanks for your patch! >

[PATCH 2/4] i2c: rcar: enable RuntimePM before registering to the core

2015-10-09 Thread Wolfram Sang
From: Wolfram Sang The core may register clients attached to this master which may use funtionality from the master. So, RuntimePM must be enabled before, otherwise this will fail. While here, move drvdata, too. Reported-by: Geert Uytterhoeven Signed-off-by: Wolfram Sang ---

Re: [PATCH 2/4] i2c: rcar: enable RuntimePM before registering to the core

2015-10-09 Thread Geert Uytterhoeven
Hi Wolfram, On Fri, Oct 9, 2015 at 8:54 AM, Wolfram Sang wrote: > The core may register clients attached to this master which may use > funtionality from the master. So, RuntimePM must be enabled before, otherwise > this will fail. While here, move drvdata, too. Thanks for

Re: [PATCH 2/4] i2c: rcar: enable RuntimePM before registering to the core

2015-10-09 Thread Wolfram Sang
> You forgot to call pm_runtime_disable() in the error path. > I think some of your other patches suffer from the same issue. Ouch! Thanks a lot, Geert! signature.asc Description: Digital signature

[PATCH 2/4] i2c: rcar: enable RuntimePM before registering to the core

2015-10-09 Thread Wolfram Sang
From: Wolfram Sang The core may register clients attached to this master which may use funtionality from the master. So, RuntimePM must be enabled before, otherwise this will fail. While here, move drvdata, too. Reported-by: Geert Uytterhoeven