Re: [PATCH 2/4] lib: Make test_sysctl initialized as module

2020-06-01 Thread Luis Chamberlain
On Thu, May 28, 2020 at 11:52:16PM +0900, Masami Hiramatsu wrote: > test_sysctl.c is expected to be used as a module, but since > it does not use module_init(), it never be registered as > a module and not appeared under /sys/module/. > In the result, the selftests/sysctl/sysctl.sh always fails > t

Re: [PATCH 2/4] lib: Make test_sysctl initialized as module

2020-05-28 Thread Kees Cook
On Thu, May 28, 2020 at 11:52:16PM +0900, Masami Hiramatsu wrote: > test_sysctl.c is expected to be used as a module, but since > it does not use module_init(), it never be registered as > a module and not appeared under /sys/module/. > In the result, the selftests/sysctl/sysctl.sh always fails > t

[PATCH 2/4] lib: Make test_sysctl initialized as module

2020-05-28 Thread Masami Hiramatsu
test_sysctl.c is expected to be used as a module, but since it does not use module_init(), it never be registered as a module and not appeared under /sys/module/. In the result, the selftests/sysctl/sysctl.sh always fails to find the test module and is skipped. This makes test_sysctl.c initialized