Re: [PATCH 2/4] mm, migrate: allocation new page lazyily in unmap_and_move()

2013-08-05 Thread Joonsoo Kim
> get_new_page() sets up result to communicate error codes from the > following checks. While the existing ones (page freed and thp split > failed) don't change rc, somebody else might add a condition whose > error code should be propagated back into *result but miss it. > > Please leave get_new_

Re: [PATCH 2/4] mm, migrate: allocation new page lazyily in unmap_and_move()

2013-08-02 Thread Johannes Weiner
On Fri, Aug 02, 2013 at 11:07:57AM +0900, Joonsoo Kim wrote: > We don't need a new page and then go out immediately if some condition > is met. Allocation has overhead in comparison with some condition check, > so allocating lazyily is preferable solution. > > Signed-off-by: Joonsoo Kim > > diff

[PATCH 2/4] mm, migrate: allocation new page lazyily in unmap_and_move()

2013-08-01 Thread Joonsoo Kim
We don't need a new page and then go out immediately if some condition is met. Allocation has overhead in comparison with some condition check, so allocating lazyily is preferable solution. Signed-off-by: Joonsoo Kim diff --git a/mm/migrate.c b/mm/migrate.c index 6f0c244..86db87e 100644 --- a/mm