Re: [PATCH 2/4] mm: remove vma arg from page_evictable

2012-09-21 Thread Mel Gorman
On Tue, Sep 18, 2012 at 08:53:45PM -0700, Hugh Dickins wrote: > page_evictable(page, vma) is an irritant: almost all its callers pass > NULL for vma. Remove the vma arg and use mlocked_vma_newpage(vma, page) > explicitly in the couple of places it's needed. But in those places we > don't even

Re: [PATCH 2/4] mm: remove vma arg from page_evictable

2012-09-21 Thread Mel Gorman
On Tue, Sep 18, 2012 at 08:53:45PM -0700, Hugh Dickins wrote: page_evictable(page, vma) is an irritant: almost all its callers pass NULL for vma. Remove the vma arg and use mlocked_vma_newpage(vma, page) explicitly in the couple of places it's needed. But in those places we don't even need

Re: [PATCH 2/4] mm: remove vma arg from page_evictable

2012-09-19 Thread Johannes Weiner
On Tue, Sep 18, 2012 at 08:53:45PM -0700, Hugh Dickins wrote: > page_evictable(page, vma) is an irritant: almost all its callers pass > NULL for vma. Remove the vma arg and use mlocked_vma_newpage(vma, page) > explicitly in the couple of places it's needed. But in those places we > don't even

Re: [PATCH 2/4] mm: remove vma arg from page_evictable

2012-09-19 Thread Johannes Weiner
On Tue, Sep 18, 2012 at 08:53:45PM -0700, Hugh Dickins wrote: page_evictable(page, vma) is an irritant: almost all its callers pass NULL for vma. Remove the vma arg and use mlocked_vma_newpage(vma, page) explicitly in the couple of places it's needed. But in those places we don't even need

[PATCH 2/4] mm: remove vma arg from page_evictable

2012-09-18 Thread Hugh Dickins
page_evictable(page, vma) is an irritant: almost all its callers pass NULL for vma. Remove the vma arg and use mlocked_vma_newpage(vma, page) explicitly in the couple of places it's needed. But in those places we don't even need page_evictable() itself! They're dealing with a freshly allocated

[PATCH 2/4] mm: remove vma arg from page_evictable

2012-09-18 Thread Hugh Dickins
page_evictable(page, vma) is an irritant: almost all its callers pass NULL for vma. Remove the vma arg and use mlocked_vma_newpage(vma, page) explicitly in the couple of places it's needed. But in those places we don't even need page_evictable() itself! They're dealing with a freshly allocated