Re: [PATCH 2/4] mtd: sh_flctl: drop unused variable

2015-05-10 Thread Nicholas Mc Guire
On Mon, 04 May 2015, Laurent Pinchart wrote: > Hi Nicholas, > > On Monday 04 May 2015 08:03:46 Nicholas Mc Guire wrote: > > On Mon, 04 May 2015, Vinod Koul wrote: > > > On Sun, May 03, 2015 at 10:33:43PM +0300, Laurent Pinchart wrote: > > > > On Saturday 02 May 2015 09:57:08 Nicholas Mc Guire

Re: [PATCH 2/4] mtd: sh_flctl: drop unused variable

2015-05-10 Thread Nicholas Mc Guire
On Mon, 04 May 2015, Laurent Pinchart wrote: Hi Nicholas, On Monday 04 May 2015 08:03:46 Nicholas Mc Guire wrote: On Mon, 04 May 2015, Vinod Koul wrote: On Sun, May 03, 2015 at 10:33:43PM +0300, Laurent Pinchart wrote: On Saturday 02 May 2015 09:57:08 Nicholas Mc Guire wrote:

Re: [PATCH 2/4] mtd: sh_flctl: drop unused variable

2015-05-04 Thread Laurent Pinchart
Hi Nicholas, On Monday 04 May 2015 08:03:46 Nicholas Mc Guire wrote: > On Mon, 04 May 2015, Vinod Koul wrote: > > On Sun, May 03, 2015 at 10:33:43PM +0300, Laurent Pinchart wrote: > > > On Saturday 02 May 2015 09:57:08 Nicholas Mc Guire wrote: > > > > shdma_tx_submit() called via

Re: [PATCH 2/4] mtd: sh_flctl: drop unused variable

2015-05-04 Thread Nicholas Mc Guire
On Mon, 04 May 2015, Vinod Koul wrote: > On Sun, May 03, 2015 at 10:33:43PM +0300, Laurent Pinchart wrote: > > Hi Nicholas, > > > > Thank you for the patch. > > > > On Saturday 02 May 2015 09:57:08 Nicholas Mc Guire wrote: > > > shdma_tx_submit() called via dmaengine_submit() returns the

Re: [PATCH 2/4] mtd: sh_flctl: drop unused variable

2015-05-04 Thread Nicholas Mc Guire
On Mon, 04 May 2015, Vinod Koul wrote: On Sun, May 03, 2015 at 10:33:43PM +0300, Laurent Pinchart wrote: Hi Nicholas, Thank you for the patch. On Saturday 02 May 2015 09:57:08 Nicholas Mc Guire wrote: shdma_tx_submit() called via dmaengine_submit() returns the assigned cookie

Re: [PATCH 2/4] mtd: sh_flctl: drop unused variable

2015-05-04 Thread Laurent Pinchart
Hi Nicholas, On Monday 04 May 2015 08:03:46 Nicholas Mc Guire wrote: On Mon, 04 May 2015, Vinod Koul wrote: On Sun, May 03, 2015 at 10:33:43PM +0300, Laurent Pinchart wrote: On Saturday 02 May 2015 09:57:08 Nicholas Mc Guire wrote: shdma_tx_submit() called via dmaengine_submit() returns

Re: [PATCH 2/4] mtd: sh_flctl: drop unused variable

2015-05-03 Thread Vinod Koul
On Sun, May 03, 2015 at 10:33:43PM +0300, Laurent Pinchart wrote: > Hi Nicholas, > > Thank you for the patch. > > On Saturday 02 May 2015 09:57:08 Nicholas Mc Guire wrote: > > shdma_tx_submit() called via dmaengine_submit() returns the assigned > > cookie but this is not used here so the

Re: [PATCH 2/4] mtd: sh_flctl: drop unused variable

2015-05-03 Thread Laurent Pinchart
Hi Nicholas, Thank you for the patch. On Saturday 02 May 2015 09:57:08 Nicholas Mc Guire wrote: > shdma_tx_submit() called via dmaengine_submit() returns the assigned > cookie but this is not used here so the variable and assignment can > be dropped. > > Signed-off-by: Nicholas Mc Guire I

Re: [PATCH 2/4] mtd: sh_flctl: drop unused variable

2015-05-03 Thread Vinod Koul
On Sun, May 03, 2015 at 10:33:43PM +0300, Laurent Pinchart wrote: Hi Nicholas, Thank you for the patch. On Saturday 02 May 2015 09:57:08 Nicholas Mc Guire wrote: shdma_tx_submit() called via dmaengine_submit() returns the assigned cookie but this is not used here so the variable and

Re: [PATCH 2/4] mtd: sh_flctl: drop unused variable

2015-05-03 Thread Laurent Pinchart
Hi Nicholas, Thank you for the patch. On Saturday 02 May 2015 09:57:08 Nicholas Mc Guire wrote: shdma_tx_submit() called via dmaengine_submit() returns the assigned cookie but this is not used here so the variable and assignment can be dropped. Signed-off-by: Nicholas Mc Guire

[PATCH 2/4] mtd: sh_flctl: drop unused variable

2015-05-02 Thread Nicholas Mc Guire
shdma_tx_submit() called via dmaengine_submit() returns the assigned cookie but this is not used here so the variable and assignment can be dropped. Signed-off-by: Nicholas Mc Guire --- V2: As pointed out by Laurent Pinchart the variable and assignment can be dropped but not the call to

[PATCH 2/4] mtd: sh_flctl: drop unused variable

2015-05-02 Thread Nicholas Mc Guire
shdma_tx_submit() called via dmaengine_submit() returns the assigned cookie but this is not used here so the variable and assignment can be dropped. Signed-off-by: Nicholas Mc Guire hof...@osadl.org --- V2: As pointed out by Laurent Pinchart laurent.pinch...@ideasonboard.com the variable