Re: [PATCH 2/4] net: freescale/fman-port: remove direct use of __devm_request_region

2020-12-03 Thread Patrick Havelange
On 2020-12-03 09:44, Madalin Bucur wrote: -Original Message- From: Patrick Havelange Sent: 02 December 2020 18:16 To: Madalin Bucur ; David S. Miller ; Jakub Kicinski ; net...@vger.kernel.org; linux-kernel@vger.kernel.org Cc: Patrick Havelange Subject: [PATCH 2/4] net: freescale/fman

RE: [PATCH 2/4] net: freescale/fman-port: remove direct use of __devm_request_region

2020-12-03 Thread Madalin Bucur
> -Original Message- > From: Patrick Havelange > Sent: 02 December 2020 18:16 > To: Madalin Bucur ; David S. Miller > ; Jakub Kicinski ; > net...@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: Patrick Havelange > Subject: [PATCH 2/4] net: freescale/fman

[PATCH 2/4] net: freescale/fman-port: remove direct use of __devm_request_region

2020-12-02 Thread Patrick Havelange
This driver was directly calling __devm_request_region with a specific resource on the stack as parameter. This is invalid as __devm_request_region expects the given resource passed as parameter to live longer than the call itself, as the pointer to the resource will be stored inside the internal