Re: [PATCH 2/4] rtc: abx80x: Enable SQW output

2021-03-30 Thread Kirill Kapranov
Hi Dan, Thank you very much for pointing out the issues. However, I'm not sure that the code, you have analyzed, will be a part of final patch set. I intend to redesign all the code deeply, as Alexandre Belloni suggested [1]. Thank you again! -- Best Regards, Kirill Kapranov Software Enginee

Re: [PATCH 2/4] rtc: abx80x: Enable SQW output

2021-03-28 Thread Dan Carpenter
Hi Kirill, url: https://github.com/0day-ci/linux/commits/Kirill-Kapranov/rtc-abx80x-Enable-distributed-digital-calibration/20210329-053233 base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next config: i386-randconfig-m021-20210328 (attached as .config) compiler:

Re: [PATCH 2/4] rtc: abx80x: Enable SQW output

2021-03-28 Thread kernel test robot
Hi Kirill, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on abelloni/rtc-next] [also build test WARNING on v5.12-rc5 next-20210326] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as do

[PATCH 2/4] rtc: abx80x: Enable SQW output

2021-03-28 Thread Kirill Kapranov
The RTCs of the family are able to produce square wave output for RTC calibration purposes or for an external usage. Signed-off-by: Kirill Kapranov --- drivers/rtc/rtc-abx80x.c | 126 +++ 1 file changed, 126 insertions(+) diff --git a/drivers/rtc/rtc-