Re: [PATCH 2/4] rtc: digicolor: set range

2019-04-30 Thread Alexandre Belloni
On 30/04/2019 18:25:52+0300, Baruch Siach wrote: > > Yes, this is ok to return a valid value that is higher than range_max. > > However, at that time, you will not be able to set any alarms anymore as > > the core doesn't allow to set alarms after range_max. > > > > I would think that this is fine

Re: [PATCH 2/4] rtc: digicolor: set range

2019-04-30 Thread Baruch Siach
Hi Alexandre, On Tue, Apr 30 2019, Alexandre Belloni wrote: > On 30/04/2019 15:20:08+0300, Baruch Siach wrote: >> On Tue, Apr 30 2019, Alexandre Belloni wrote: >> > On 30/04/2019 14:36:24+0300, Baruch Siach wrote: >> >> Hi Alexandre, >> >> >> >> On Tue, Apr 30 2019, Alexandre Belloni wrote: >> >>

Re: [PATCH 2/4] rtc: digicolor: set range

2019-04-30 Thread Alexandre Belloni
On 30/04/2019 15:20:08+0300, Baruch Siach wrote: > Hi Alexandre, > > On Tue, Apr 30 2019, Alexandre Belloni wrote: > > On 30/04/2019 14:36:24+0300, Baruch Siach wrote: > >> Hi Alexandre, > >> > >> On Tue, Apr 30 2019, Alexandre Belloni wrote: > >> > >> > While the range of REFERENCE + TIME is

Re: [PATCH 2/4] rtc: digicolor: set range

2019-04-30 Thread Baruch Siach
Hi Alexandre, On Tue, Apr 30 2019, Alexandre Belloni wrote: > On 30/04/2019 14:36:24+0300, Baruch Siach wrote: >> Hi Alexandre, >> >> On Tue, Apr 30 2019, Alexandre Belloni wrote: >> >> > While the range of REFERENCE + TIME is actually 33 bits, the counter >> > itself (TIME) is a 32-bits seconds

Re: [PATCH 2/4] rtc: digicolor: set range

2019-04-30 Thread Alexandre Belloni
On 30/04/2019 14:36:24+0300, Baruch Siach wrote: > Hi Alexandre, > > On Tue, Apr 30 2019, Alexandre Belloni wrote: > > > While the range of REFERENCE + TIME is actually 33 bits, the counter > > itself (TIME) is a 32-bits seconds counter. > > > > Signed-off-by: Alexandre Belloni > > --- > >

Re: [PATCH 2/4] rtc: digicolor: set range

2019-04-30 Thread Baruch Siach
Hi Alexandre, On Tue, Apr 30 2019, Alexandre Belloni wrote: > While the range of REFERENCE + TIME is actually 33 bits, the counter > itself (TIME) is a 32-bits seconds counter. > > Signed-off-by: Alexandre Belloni > --- > drivers/rtc/rtc-digicolor.c | 1 + > 1 file changed, 1 insertion(+) > >

[PATCH 2/4] rtc: digicolor: set range

2019-04-30 Thread Alexandre Belloni
While the range of REFERENCE + TIME is actually 33 bits, the counter itself (TIME) is a 32-bits seconds counter. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-digicolor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc/rtc-digicolor.c index