Re: [PATCH 2/4 -v5] x86_64 EFI runtime service support: EFI runtime services

2007-10-30 Thread Huang, Ying
On Tue, 2007-10-30 at 15:58 +, Denys Vlasenko wrote: > On Tuesday 30 October 2007 05:55, Huang, Ying wrote: > > +static inline unsigned long native_get_wallclock(void) > > +{ > > + unsigned long retval; > > + > > + if (efi_enabled) > > + retval = efi_get_time(); > > + else > >

Re: [PATCH 2/4 -v5] x86_64 EFI runtime service support: EFI runtime services

2007-10-30 Thread Thomas Gleixner
On Tue, 30 Oct 2007, Denys Vlasenko wrote: > mach_get_cmos_time() is itself an inline, and a _large_ one > (~20 LOC with macro and function calls). > > Same here, only mach_set_rtc_mmss is 50 LOC, not 20. It was:)

Re: [PATCH 2/4 -v5] x86_64 EFI runtime service support: EFI runtime services

2007-10-30 Thread Denys Vlasenko
On Tuesday 30 October 2007 05:55, Huang, Ying wrote: > +static inline unsigned long native_get_wallclock(void) > +{ > + unsigned long retval; > + > + if (efi_enabled) > + retval = efi_get_time(); > + else > + retval = mach_get_cmos_time(); > + > + return

Re: [PATCH 2/4 -v5] x86_64 EFI runtime service support: EFI runtime services

2007-10-30 Thread Denys Vlasenko
On Tuesday 30 October 2007 05:55, Huang, Ying wrote: +static inline unsigned long native_get_wallclock(void) +{ + unsigned long retval; + + if (efi_enabled) + retval = efi_get_time(); + else + retval = mach_get_cmos_time(); + + return retval; +}

Re: [PATCH 2/4 -v5] x86_64 EFI runtime service support: EFI runtime services

2007-10-30 Thread Thomas Gleixner
On Tue, 30 Oct 2007, Denys Vlasenko wrote: mach_get_cmos_time() is itself an inline, and a _large_ one (~20 LOC with macro and function calls). Same here, only mach_set_rtc_mmss is 50 LOC, not 20. It was:)

Re: [PATCH 2/4 -v5] x86_64 EFI runtime service support: EFI runtime services

2007-10-30 Thread Huang, Ying
On Tue, 2007-10-30 at 15:58 +, Denys Vlasenko wrote: On Tuesday 30 October 2007 05:55, Huang, Ying wrote: +static inline unsigned long native_get_wallclock(void) +{ + unsigned long retval; + + if (efi_enabled) + retval = efi_get_time(); + else +

[PATCH 2/4 -v5] x86_64 EFI runtime service support: EFI runtime services

2007-10-29 Thread Huang, Ying
This patch adds support for several EFI runtime services for EFI x86_64 system. The EFI support for emergency_restart and RTC clock is added. The EFI based implementation and legacy BIOS or CMOS based implementation are put in separate functions and can be chosen with kernel boot options.

[PATCH 2/4 -v5] x86_64 EFI runtime service support: EFI runtime services

2007-10-29 Thread Huang, Ying
This patch adds support for several EFI runtime services for EFI x86_64 system. The EFI support for emergency_restart and RTC clock is added. The EFI based implementation and legacy BIOS or CMOS based implementation are put in separate functions and can be chosen with kernel boot options.