Re: [PATCH 2/4 v2] mm: fix possible incorrect return value of migrate_pages() syscall

2012-07-17 Thread JoonSoo Kim
2012/7/17 Christoph Lameter : > On Tue, 17 Jul 2012, Joonsoo Kim wrote: > >> @@ -1382,6 +1382,8 @@ SYSCALL_DEFINE4(migrate_pages, pid_t, pid, unsigned >> long, maxnode, >> >> err = do_migrate_pages(mm, old, new, >> capable(CAP_SYS_NICE) ? MPOL_MF_MOVE_ALL : MPOL_MF_MOVE); >> +

Re: [PATCH 2/4 v2] mm: fix possible incorrect return value of migrate_pages() syscall

2012-07-17 Thread Christoph Lameter
On Tue, 17 Jul 2012, Joonsoo Kim wrote: > @@ -1382,6 +1382,8 @@ SYSCALL_DEFINE4(migrate_pages, pid_t, pid, unsigned > long, maxnode, > > err = do_migrate_pages(mm, old, new, > capable(CAP_SYS_NICE) ? MPOL_MF_MOVE_ALL : MPOL_MF_MOVE); > + if (err > 0) > + err =

[PATCH 2/4 v2] mm: fix possible incorrect return value of migrate_pages() syscall

2012-07-17 Thread Joonsoo Kim
do_migrate_pages() can return the number of pages not migrated. Because migrate_pages() syscall return this value directly, migrate_pages() syscall may return the number of pages not migrated. In fail case in migrate_pages() syscall, we should return error value. So change err to -EBUSY Additional