Re: [PATCH 2/5] ACPI: Reorder IPMI driver before any other ACPI drivers

2012-10-22 Thread Matthew Garrett
On Mon, Oct 22, 2012 at 05:07:03PM -0700, Andrew Morton wrote: > On Tue, 23 Oct 2012 01:00:34 +0100 > Matthew Garrett wrote: > > Not really - some of this code can be built as modules, so it's mostly > > module_init rather than anything from the initcall family. > > > > hm. So the ACPI code

Re: [PATCH 2/5] ACPI: Reorder IPMI driver before any other ACPI drivers

2012-10-22 Thread Andrew Morton
On Tue, 23 Oct 2012 01:00:34 +0100 Matthew Garrett wrote: > On Mon, Oct 22, 2012 at 04:45:38PM -0700, Andrew Morton wrote: > > > Relying upon link ordering is the old-fashioned way of doing things, > > and I have vague memories that it only works by luck - that there's no > > hard-and-fast rule

Re: [PATCH 2/5] ACPI: Reorder IPMI driver before any other ACPI drivers

2012-10-22 Thread Matthew Garrett
On Mon, Oct 22, 2012 at 04:45:38PM -0700, Andrew Morton wrote: > Relying upon link ordering is the old-fashioned way of doing things, > and I have vague memories that it only works by luck - that there's no > hard-and-fast rule that the linker has to obey what we think we asked > it to do. > >

Re: [PATCH 2/5] ACPI: Reorder IPMI driver before any other ACPI drivers

2012-10-22 Thread Andrew Morton
On Tue, 16 Oct 2012 15:53:37 -0500 miny...@acm.org wrote: > From: Matthew Garrett > > Drivers may make calls that require the ACPI IPMI driver to have been > initialised already, so make sure that it appears earlier in the build > order. > > ... > > index 47199e2..82422fe 100644 > ---

Re: [PATCH 2/5] ACPI: Reorder IPMI driver before any other ACPI drivers

2012-10-22 Thread Andrew Morton
On Tue, 16 Oct 2012 15:53:37 -0500 miny...@acm.org wrote: From: Matthew Garrett m...@redhat.com Drivers may make calls that require the ACPI IPMI driver to have been initialised already, so make sure that it appears earlier in the build order. ... index 47199e2..82422fe 100644 ---

Re: [PATCH 2/5] ACPI: Reorder IPMI driver before any other ACPI drivers

2012-10-22 Thread Matthew Garrett
On Mon, Oct 22, 2012 at 04:45:38PM -0700, Andrew Morton wrote: Relying upon link ordering is the old-fashioned way of doing things, and I have vague memories that it only works by luck - that there's no hard-and-fast rule that the linker has to obey what we think we asked it to do. The

Re: [PATCH 2/5] ACPI: Reorder IPMI driver before any other ACPI drivers

2012-10-22 Thread Andrew Morton
On Tue, 23 Oct 2012 01:00:34 +0100 Matthew Garrett mj...@srcf.ucam.org wrote: On Mon, Oct 22, 2012 at 04:45:38PM -0700, Andrew Morton wrote: Relying upon link ordering is the old-fashioned way of doing things, and I have vague memories that it only works by luck - that there's no

Re: [PATCH 2/5] ACPI: Reorder IPMI driver before any other ACPI drivers

2012-10-22 Thread Matthew Garrett
On Mon, Oct 22, 2012 at 05:07:03PM -0700, Andrew Morton wrote: On Tue, 23 Oct 2012 01:00:34 +0100 Matthew Garrett mj...@srcf.ucam.org wrote: Not really - some of this code can be built as modules, so it's mostly module_init rather than anything from the initcall family. hm. So the

[PATCH 2/5] ACPI: Reorder IPMI driver before any other ACPI drivers

2012-10-16 Thread minyard
From: Matthew Garrett Drivers may make calls that require the ACPI IPMI driver to have been initialised already, so make sure that it appears earlier in the build order. Signed-off-by: Matthew Garrett Signed-off-by: Corey Minyard --- drivers/acpi/Makefile |5 - 1 files changed, 4

[PATCH 2/5] ACPI: Reorder IPMI driver before any other ACPI drivers

2012-10-16 Thread minyard
From: Matthew Garrett m...@redhat.com Drivers may make calls that require the ACPI IPMI driver to have been initialised already, so make sure that it appears earlier in the build order. Signed-off-by: Matthew Garrett m...@redhat.com Signed-off-by: Corey Minyard cminy...@mvista.com ---