Re: [PATCH 2/5] Input: bu21013_ts - Move GPIO init and exit functions into the driver

2012-11-26 Thread Lee Jones
On Fri, 23 Nov 2012, Dmitry Torokhov wrote: > Hi Lee, > > On Thu, Nov 22, 2012 at 12:10:30PM +, Lee Jones wrote: > > > > /** > > + * bu21013_gpio_board_init() - configures the touch panel > > + * @reset_pin: reset pin number > > + * > > + * This function is used to configure the voltage an

Re: [PATCH 2/5] Input: bu21013_ts - Move GPIO init and exit functions into the driver

2012-11-23 Thread Dmitry Torokhov
Hi Lee, On Thu, Nov 22, 2012 at 12:10:30PM +, Lee Jones wrote: > > /** > + * bu21013_gpio_board_init() - configures the touch panel > + * @reset_pin: reset pin number > + * > + * This function is used to configure the voltage and > + * reset the touch panel controller. > + */ > +static int

Re: [PATCH 2/5] Input: bu21013_ts - Move GPIO init and exit functions into the driver

2012-11-23 Thread Lee Jones
On Thu, 22 Nov 2012, Lee Jones wrote: > Author: Lee Jones > Date: Fri Sep 28 10:29:07 2012 +0100 > > Input: bu21013_ts - Move GPIO init and exit functions into the driver > > These GPIO init and exit functions have no place in platform data. > Instead they should be part of th

Re: [PATCH 2/5] Input: bu21013_ts - Move GPIO init and exit functions into the driver

2012-11-22 Thread Lee Jones
Author: Lee Jones Date: Fri Sep 28 10:29:07 2012 +0100 Input: bu21013_ts - Move GPIO init and exit functions into the driver These GPIO init and exit functions have no place in platform data. Instead they should be part of the driver. This patch moves them to their rightful

Re: [PATCH 2/5] Input: bu21013_ts - Move GPIO init and exit functions into the driver

2012-11-22 Thread Lee Jones
On Wed, 21 Nov 2012, Dmitry Torokhov wrote: > Hi Lee, > > On Wed, Nov 14, 2012 at 01:47:14PM +, Lee Jones wrote: > > @@ -272,6 +276,60 @@ static irqreturn_t bu21013_gpio_irq(int irq, void > > *device_data) > > } > > > > /** > > + * bu21013_gpio_board_init() - configures the touch panel >

Re: [PATCH 2/5] Input: bu21013_ts - Move GPIO init and exit functions into the driver

2012-11-21 Thread Dmitry Torokhov
Hi Lee, On Wed, Nov 14, 2012 at 01:47:14PM +, Lee Jones wrote: > @@ -272,6 +276,60 @@ static irqreturn_t bu21013_gpio_irq(int irq, void > *device_data) > } > > /** > + * bu21013_gpio_board_init() - configures the touch panel > + * @reset_pin: reset pin number > + * > + * This function is

[PATCH 2/5] Input: bu21013_ts - Move GPIO init and exit functions into the driver

2012-11-14 Thread Lee Jones
These GPIO init and exit functions have no place in platform data. Instead they should be part of the driver. This patch moves them to their rightful place, which subsequently elevates platform data of yet more cruft. Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org Acked-by: Arnd Bergmann Ac