Re: [PATCH 2/5] coredump: Fix handling of partial writes in dump_emit()

2020-04-28 Thread Linus Torvalds
On Tue, Apr 28, 2020 at 9:34 AM Rob Landley wrote: > > Writes to a local filesystem should never be short unless disk full/error. Well, that code is definitely supposed to also write to pipes. But it also has "was I interrupted" logic, which stops the core dump. So short writes can very much

Re: [PATCH 2/5] coredump: Fix handling of partial writes in dump_emit()

2020-04-28 Thread Rob Landley
On 4/27/20 10:35 PM, Linus Torvalds wrote: > On Mon, Apr 27, 2020 at 8:28 PM Jann Horn wrote: >> >> After a partial write, we have to update the input buffer pointer. > > Interesting. It seems this partial write case never triggers (except > for actually killing the core-dump). > > Or did you