Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

On Tue, May 23, 2017 at 12:27 PM, Chanwoo Choi wrote: > Hi Hans, > > I'm sorry for late reply. > I'll check this thread and then give you my opinion. Just don't forget to Cc your mails to USB Type-C people (Heikki et al). -- With Best Regards, Andy Shevchenko

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

On Tue, May 23, 2017 at 12:27 PM, Chanwoo Choi wrote: > Hi Hans, > > I'm sorry for late reply. > I'll check this thread and then give you my opinion. Just don't forget to Cc your mails to USB Type-C people (Heikki et al). -- With Best Regards, Andy Shevchenko

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

Hi Hans, I'm sorry for late reply. I'll check this thread and then give you my opinion. Regards, Chanwoo Choi On 2017년 04월 21일 22:01, Hans de Goede wrote: > Add support for USB TYPE-C cable detection on systems using a > FUSB302 USB TYPE-C controller. > > Signed-off-by: Hans de Goede

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

Hi Hans, I'm sorry for late reply. I'll check this thread and then give you my opinion. Regards, Chanwoo Choi On 2017년 04월 21일 22:01, Hans de Goede wrote: > Add support for USB TYPE-C cable detection on systems using a > FUSB302 USB TYPE-C controller. > > Signed-off-by: Hans de Goede > --- >

Re: USB TYPE-C support and the power-supply subsys (was Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support)

On Fri, May 19, 2017 at 10:12:14PM +0200, Hans de Goede wrote: > Hi, > > On 18-05-17 10:37, Heikki Krogerus wrote: > > On Wed, May 17, 2017 at 04:47:14PM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 17-05-17 13:45, Heikki Krogerus wrote: > > > > > > > In this case the driver for

Re: USB TYPE-C support and the power-supply subsys (was Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support)

On Fri, May 19, 2017 at 10:12:14PM +0200, Hans de Goede wrote: > Hi, > > On 18-05-17 10:37, Heikki Krogerus wrote: > > On Wed, May 17, 2017 at 04:47:14PM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 17-05-17 13:45, Heikki Krogerus wrote: > > > > > > > In this case the driver for

Re: USB TYPE-C support and the power-supply subsys (was Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support)

Hi, On 19-05-17 22:12, Hans de Goede wrote: Hi, On 18-05-17 10:37, Heikki Krogerus wrote: On Wed, May 17, 2017 at 04:47:14PM +0200, Hans de Goede wrote: Hi, On 17-05-17 13:45, Heikki Krogerus wrote: In this case the driver for fusb302 registers a power supply that provides properties

Re: USB TYPE-C support and the power-supply subsys (was Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support)

Hi, On 19-05-17 22:12, Hans de Goede wrote: Hi, On 18-05-17 10:37, Heikki Krogerus wrote: On Wed, May 17, 2017 at 04:47:14PM +0200, Hans de Goede wrote: Hi, On 17-05-17 13:45, Heikki Krogerus wrote: In this case the driver for fusb302 registers a power supply that provides properties

Re: USB TYPE-C support and the power-supply subsys (was Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support)

Hi, On 18-05-17 10:37, Heikki Krogerus wrote: On Wed, May 17, 2017 at 04:47:14PM +0200, Hans de Goede wrote: Hi, On 17-05-17 13:45, Heikki Krogerus wrote: In this case the driver for fusb302 registers a power supply that provides properties like POWER_SUPPLY_PROP_VOLTAGE_MAX, etc. and

Re: USB TYPE-C support and the power-supply subsys (was Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support)

Hi, On 18-05-17 10:37, Heikki Krogerus wrote: On Wed, May 17, 2017 at 04:47:14PM +0200, Hans de Goede wrote: Hi, On 17-05-17 13:45, Heikki Krogerus wrote: In this case the driver for fusb302 registers a power supply that provides properties like POWER_SUPPLY_PROP_VOLTAGE_MAX, etc. and

Re: USB TYPE-C support and the power-supply subsys (was Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support)

On Thu, May 18, 2017 at 11:37:56AM +0300, Heikki Krogerus wrote: > I'm mainly interested in just considering USB as a power supply with a > board like this, because really, that is what it is, but also by using > the power supply class properly (and possibly improving it a little), > we avoid

Re: USB TYPE-C support and the power-supply subsys (was Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support)

On Thu, May 18, 2017 at 11:37:56AM +0300, Heikki Krogerus wrote: > I'm mainly interested in just considering USB as a power supply with a > board like this, because really, that is what it is, but also by using > the power supply class properly (and possibly improving it a little), > we avoid

Re: USB TYPE-C support and the power-supply subsys (was Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support)

On Wed, May 17, 2017 at 04:47:14PM +0200, Hans de Goede wrote: > Hi, > > On 17-05-17 13:45, Heikki Krogerus wrote: > > Hi, > > > > On Wed, May 17, 2017 at 12:24:52AM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 05/16/2017 02:07 PM, Heikki Krogerus wrote: > > > But we don't really have

Re: USB TYPE-C support and the power-supply subsys (was Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support)

On Wed, May 17, 2017 at 04:47:14PM +0200, Hans de Goede wrote: > Hi, > > On 17-05-17 13:45, Heikki Krogerus wrote: > > Hi, > > > > On Wed, May 17, 2017 at 12:24:52AM +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 05/16/2017 02:07 PM, Heikki Krogerus wrote: > > > But we don't really have

USB TYPE-C support and the power-supply subsys (was Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support)

Hi, On 17-05-17 13:45, Heikki Krogerus wrote: Hi, On Wed, May 17, 2017 at 12:24:52AM +0200, Hans de Goede wrote: Hi, On 05/16/2017 02:07 PM, Heikki Krogerus wrote: But we don't really have multiple sources here, we have only one source, the USB-C cable hooked to an external power-supply.

USB TYPE-C support and the power-supply subsys (was Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support)

Hi, On 17-05-17 13:45, Heikki Krogerus wrote: Hi, On Wed, May 17, 2017 at 12:24:52AM +0200, Hans de Goede wrote: Hi, On 05/16/2017 02:07 PM, Heikki Krogerus wrote: But we don't really have multiple sources here, we have only one source, the USB-C cable hooked to an external power-supply.

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

Hi, On Wed, May 17, 2017 at 12:24:52AM +0200, Hans de Goede wrote: > Hi, > > On 05/16/2017 02:07 PM, Heikki Krogerus wrote: > > Hi Hans, > > > > On Fri, May 12, 2017 at 11:22:46PM +0200, Hans de Goede wrote: > > > > > > To me making the combination of the 2 sources the problem > > > of the

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

Hi, On Wed, May 17, 2017 at 12:24:52AM +0200, Hans de Goede wrote: > Hi, > > On 05/16/2017 02:07 PM, Heikki Krogerus wrote: > > Hi Hans, > > > > On Fri, May 12, 2017 at 11:22:46PM +0200, Hans de Goede wrote: > > > > > > To me making the combination of the 2 sources the problem > > > of the

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

On Fri, May 12, 2017 at 11:22:46PM +0200, Hans de Goede wrote: > Hi, > > On 24-04-17 15:12, Guenter Roeck wrote: > >On 04/24/2017 04:02 AM, Heikki Krogerus wrote: > >>+Guenter > >> > >>On Fri, Apr 21, 2017 at 09:51:50PM +0300, Andy Shevchenko wrote: > >>>+Cc: Heikki. > >>> > >>>He might comment

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

On Fri, May 12, 2017 at 11:22:46PM +0200, Hans de Goede wrote: > Hi, > > On 24-04-17 15:12, Guenter Roeck wrote: > >On 04/24/2017 04:02 AM, Heikki Krogerus wrote: > >>+Guenter > >> > >>On Fri, Apr 21, 2017 at 09:51:50PM +0300, Andy Shevchenko wrote: > >>>+Cc: Heikki. > >>> > >>>He might comment

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

Hi, On 05/16/2017 02:07 PM, Heikki Krogerus wrote: Hi Hans, On Fri, May 12, 2017 at 11:22:46PM +0200, Hans de Goede wrote: To me making the combination of the 2 sources the problem of the consumer seems just wrong, as you mentioned above there should really be only one extcon for the

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

Hi, On 05/16/2017 02:07 PM, Heikki Krogerus wrote: Hi Hans, On Fri, May 12, 2017 at 11:22:46PM +0200, Hans de Goede wrote: To me making the combination of the 2 sources the problem of the consumer seems just wrong, as you mentioned above there should really be only one extcon for the

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

Hi Hans, On Fri, May 12, 2017 at 11:22:46PM +0200, Hans de Goede wrote: > On 24-04-17 16:25, Heikki Krogerus wrote: > > > Doesn't this mean you have several extcon_dev registered for a > > single port? > > Yes this is unfortunate, but the primary consumer of extcon > info is the kernel itself

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

Hi Hans, On Fri, May 12, 2017 at 11:22:46PM +0200, Hans de Goede wrote: > On 24-04-17 16:25, Heikki Krogerus wrote: > > > Doesn't this mean you have several extcon_dev registered for a > > single port? > > Yes this is unfortunate, but the primary consumer of extcon > info is the kernel itself

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

Hi, On 24-04-17 15:12, Guenter Roeck wrote: On 04/24/2017 04:02 AM, Heikki Krogerus wrote: +Guenter On Fri, Apr 21, 2017 at 09:51:50PM +0300, Andy Shevchenko wrote: +Cc: Heikki. He might comment on this. Thanks Andy. On Fri, Apr 21, 2017 at 4:01 PM, Hans de Goede

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

Hi, On 24-04-17 15:12, Guenter Roeck wrote: On 04/24/2017 04:02 AM, Heikki Krogerus wrote: +Guenter On Fri, Apr 21, 2017 at 09:51:50PM +0300, Andy Shevchenko wrote: +Cc: Heikki. He might comment on this. Thanks Andy. On Fri, Apr 21, 2017 at 4:01 PM, Hans de Goede wrote: Add support

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

On 04/24/2017 04:02 AM, Heikki Krogerus wrote: +Guenter On Fri, Apr 21, 2017 at 09:51:50PM +0300, Andy Shevchenko wrote: +Cc: Heikki. He might comment on this. Thanks Andy. On Fri, Apr 21, 2017 at 4:01 PM, Hans de Goede wrote: Add support for USB TYPE-C cable

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

On 04/24/2017 04:02 AM, Heikki Krogerus wrote: +Guenter On Fri, Apr 21, 2017 at 09:51:50PM +0300, Andy Shevchenko wrote: +Cc: Heikki. He might comment on this. Thanks Andy. On Fri, Apr 21, 2017 at 4:01 PM, Hans de Goede wrote: Add support for USB TYPE-C cable detection on systems using

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

+Guenter On Fri, Apr 21, 2017 at 09:51:50PM +0300, Andy Shevchenko wrote: > +Cc: Heikki. > > He might comment on this. Thanks Andy. > On Fri, Apr 21, 2017 at 4:01 PM, Hans de Goede wrote: > > Add support for USB TYPE-C cable detection on systems using a > > FUSB302 USB

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

+Guenter On Fri, Apr 21, 2017 at 09:51:50PM +0300, Andy Shevchenko wrote: > +Cc: Heikki. > > He might comment on this. Thanks Andy. > On Fri, Apr 21, 2017 at 4:01 PM, Hans de Goede wrote: > > Add support for USB TYPE-C cable detection on systems using a > > FUSB302 USB TYPE-C controller. > >

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

Hi Hans, [auto build test ERROR on chanwoo-extcon/extcon-next] [also build test ERROR on v4.11-rc7 next-20170421] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

Hi Hans, [auto build test ERROR on chanwoo-extcon/extcon-next] [also build test ERROR on v4.11-rc7 next-20170421] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

+Cc: Heikki. He might comment on this. On Fri, Apr 21, 2017 at 4:01 PM, Hans de Goede wrote: > Add support for USB TYPE-C cable detection on systems using a > FUSB302 USB TYPE-C controller. > > Signed-off-by: Hans de Goede > --- >

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

+Cc: Heikki. He might comment on this. On Fri, Apr 21, 2017 at 4:01 PM, Hans de Goede wrote: > Add support for USB TYPE-C cable detection on systems using a > FUSB302 USB TYPE-C controller. > > Signed-off-by: Hans de Goede > --- > drivers/extcon/Kconfig | 8 + >

[PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

Add support for USB TYPE-C cable detection on systems using a FUSB302 USB TYPE-C controller. Signed-off-by: Hans de Goede --- drivers/extcon/Kconfig | 8 + drivers/extcon/Makefile | 1 + drivers/extcon/extcon-fusb302.c | 782

[PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

Add support for USB TYPE-C cable detection on systems using a FUSB302 USB TYPE-C controller. Signed-off-by: Hans de Goede --- drivers/extcon/Kconfig | 8 + drivers/extcon/Makefile | 1 + drivers/extcon/extcon-fusb302.c | 782 3 files