Re: [PATCH 2/5] iio: Add support for LMP92001 ADC

Hi Abhisit, On Sun, Aug 20, 2017 at 11:31:41AM +0100, Jonathan Cameron wrote: > On Fri, 18 Aug 2017 14:42:59 +0700 > Abhisit Sangjan wrote: > > > Hi Jmondi, > > > > After I removed those cases, I got warnings "no handled in switch". > > > > On Fri, Aug 18, 2017 at 10:15 AM,

Re: [PATCH 2/5] iio: Add support for LMP92001 ADC

Hi Abhisit, On Sun, Aug 20, 2017 at 11:31:41AM +0100, Jonathan Cameron wrote: > On Fri, 18 Aug 2017 14:42:59 +0700 > Abhisit Sangjan wrote: > > > Hi Jmondi, > > > > After I removed those cases, I got warnings "no handled in switch". > > > > On Fri, Aug 18, 2017 at 10:15 AM, Abhisit Sangjan > >

Re: [PATCH 2/5] iio: Add support for LMP92001 ADC

On Fri, 18 Aug 2017 14:42:59 +0700 Abhisit Sangjan wrote: > Hi Jmondi, > > After I removed those cases, I got warnings "no handled in switch". > > On Fri, Aug 18, 2017 at 10:15 AM, Abhisit Sangjan > wrote: > > > Hi Jmondi, > > > > On Fri, Aug 18,

Re: [PATCH 2/5] iio: Add support for LMP92001 ADC

On Fri, 18 Aug 2017 14:42:59 +0700 Abhisit Sangjan wrote: > Hi Jmondi, > > After I removed those cases, I got warnings "no handled in switch". > > On Fri, Aug 18, 2017 at 10:15 AM, Abhisit Sangjan > wrote: > > > Hi Jmondi, > > > > On Fri, Aug 18, 2017 at 9:58 AM, jmondi wrote: > > > >> Hi

Re: [PATCH 2/5] iio: Add support for LMP92001 ADC

Hi Abhisit, On Fri, Aug 18, 2017 at 09:34:16AM +0700, Abhisit Sangjan wrote: > Hi Jmondi, > > Thank you for your recommend, I am testing the code will be send the new > patch in soon. [snip] > > > > + > > > > +switch (mask) > > > > +{ > > > > +case IIO_CHAN_INFO_RAW: > >

Re: [PATCH 2/5] iio: Add support for LMP92001 ADC

Hi Abhisit, On Fri, Aug 18, 2017 at 09:34:16AM +0700, Abhisit Sangjan wrote: > Hi Jmondi, > > Thank you for your recommend, I am testing the code will be send the new > patch in soon. [snip] > > > > + > > > > +switch (mask) > > > > +{ > > > > +case IIO_CHAN_INFO_RAW: > >

Re: [PATCH 2/5] iio: Add support for LMP92001 ADC

Hi Abhisit, On Thu, Aug 03, 2017 at 12:40:49PM +0200, Peter Meerwald-Stadler wrote: > > > From: Abhisit Sangjan > > some more comments in addition to Jonathan's and some more here... As a general one, I see all code indented with spaces O_0 Please run checkpatch as

Re: [PATCH 2/5] iio: Add support for LMP92001 ADC

Hi Abhisit, On Thu, Aug 03, 2017 at 12:40:49PM +0200, Peter Meerwald-Stadler wrote: > > > From: Abhisit Sangjan > > some more comments in addition to Jonathan's and some more here... As a general one, I see all code indented with spaces O_0 Please run checkpatch as Jonathan said, and instruct

Re: [PATCH 2/5] iio: Add support for LMP92001 ADC

On Wed, 2 Aug 2017 14:06:50 +0700 Abhisit Sangjan wrote: > Hi Jonathan, > > Please find my comment on in line. > > Thank you. > Abhisit S. > > >> > +#include > >> > +#include > >> > +#include > >> > +#include > >> > +#include > >> > +#include > >> > + > >> >

Re: [PATCH 2/5] iio: Add support for LMP92001 ADC

On Wed, 2 Aug 2017 14:06:50 +0700 Abhisit Sangjan wrote: > Hi Jonathan, > > Please find my comment on in line. > > Thank you. > Abhisit S. > > >> > +#include > >> > +#include > >> > +#include > >> > +#include > >> > +#include > >> > +#include > >> > + > >> > +#include > >> > + > >> >

Re: [PATCH 2/5] iio: Add support for LMP92001 ADC

> From: Abhisit Sangjan some more comments in addition to Jonathan's > --- > drivers/iio/adc/Kconfig| 10 + > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/lmp92001-adc.c | 479 > + > 3 files changed, 490

Re: [PATCH 2/5] iio: Add support for LMP92001 ADC

> From: Abhisit Sangjan some more comments in addition to Jonathan's > --- > drivers/iio/adc/Kconfig| 10 + > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/lmp92001-adc.c | 479 > + > 3 files changed, 490 insertions(+) > create

Re: [PATCH 2/5] iio: Add support for LMP92001 ADC

On Tue, 1 Aug 2017 16:12:22 +0700 wrote: > From: Abhisit Sangjan Hi, A very quick initial review covering stuff you'll want to clean up before you get some in depth reviews. 1) Please cc linux-iio on the whole series - it's useful to see the mfd

Re: [PATCH 2/5] iio: Add support for LMP92001 ADC

On Tue, 1 Aug 2017 16:12:22 +0700 wrote: > From: Abhisit Sangjan Hi, A very quick initial review covering stuff you'll want to clean up before you get some in depth reviews. 1) Please cc linux-iio on the whole series - it's useful to see the mfd driver and review it as well. 2) Description

[PATCH 2/5] iio: Add support for LMP92001 ADC

From: Abhisit Sangjan --- drivers/iio/adc/Kconfig| 10 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/lmp92001-adc.c | 479 + 3 files changed, 490 insertions(+) create mode 100644 drivers/iio/adc/lmp92001-adc.c

[PATCH 2/5] iio: Add support for LMP92001 ADC

From: Abhisit Sangjan --- drivers/iio/adc/Kconfig| 10 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/lmp92001-adc.c | 479 + 3 files changed, 490 insertions(+) create mode 100644 drivers/iio/adc/lmp92001-adc.c diff --git