Dear Tomasz,
About a hardcode your comment, please help check below.
Dear Mark,
I would like to add a item in the dtsi of mtk-iommu. Please also
help have a look.
> > > +static const struct mtk_iommu_port mtk_iommu_mt8173_port[] = {
> > > + /* port namem4uid
Dear Tomasz,
About a hardcode your comment, please help check below.
Dear Mark,
I would like to add a item in the dtsi of mtk-iommu. Please also
help have a look.
+static const struct mtk_iommu_port mtk_iommu_mt8173_port[] = {
+ /* port namem4uid slaveid
On Wed, Apr 15, 2015 at 4:06 PM, Yong Wu wrote:
> On Wed, 2015-04-15 at 11:20 +0900, Tomasz Figa wrote:
>> On Tue, Apr 14, 2015 at 3:31 PM, Yong Wu wrote:
>> >> >>
>> >> >> > +
>> >> >> > + piommu->protect_va = devm_kmalloc(piommu->dev,
>> >> >> > MTK_PROTECT_PA_ALIGN*2,
>> >> >>
>> >> >>
On Wed, 2015-04-15 at 11:20 +0900, Tomasz Figa wrote:
> On Tue, Apr 14, 2015 at 3:31 PM, Yong Wu wrote:
> >> >>
> >> >> > +
> >> >> > + piommu->protect_va = devm_kmalloc(piommu->dev,
> >> >> > MTK_PROTECT_PA_ALIGN*2,
> >> >>
> >> >> style: Operators like * should have space on both sides.
On Wed, 2015-04-15 at 11:20 +0900, Tomasz Figa wrote:
On Tue, Apr 14, 2015 at 3:31 PM, Yong Wu yong...@mediatek.com wrote:
+
+ piommu-protect_va = devm_kmalloc(piommu-dev,
MTK_PROTECT_PA_ALIGN*2,
style: Operators like * should have space on both sides.
+
On Wed, Apr 15, 2015 at 4:06 PM, Yong Wu yong...@mediatek.com wrote:
On Wed, 2015-04-15 at 11:20 +0900, Tomasz Figa wrote:
On Tue, Apr 14, 2015 at 3:31 PM, Yong Wu yong...@mediatek.com wrote:
+
+ piommu-protect_va = devm_kmalloc(piommu-dev,
MTK_PROTECT_PA_ALIGN*2,
On Tue, Apr 14, 2015 at 3:31 PM, Yong Wu wrote:
>> >>
>> >> > +
>> >> > + piommu->protect_va = devm_kmalloc(piommu->dev,
>> >> > MTK_PROTECT_PA_ALIGN*2,
>> >>
>> >> style: Operators like * should have space on both sides.
>> >>
>> >> > + GFP_KERNEL);
Hi Robin,
Thanks very much for your confirm.
About the v3 of the DMA-mapping, I have some question below.
On Fri, 2015-03-20 at 19:14 +, Robin Murphy wrote:
> On 18/03/15 11:22, Yong Wu wrote:
> > Hi Tomasz,
> > Thanks very much for your review. please help check below.
> >
Hi Tomasz,
Thanks very much for you suggestion and explain so detail.
please help check below.
On Fri, 2015-03-27 at 18:41 +0900, Tomasz Figa wrote:
> Hi Yong Wu,
>
> Sorry for long delay, I had to figure out some time to look at this again.
>
> On Wed, Mar 18, 2015 at 8:22 PM, Yong
Hi Robin,
Thanks very much for your confirm.
About the v3 of the DMA-mapping, I have some question below.
On Fri, 2015-03-20 at 19:14 +, Robin Murphy wrote:
On 18/03/15 11:22, Yong Wu wrote:
Hi Tomasz,
Thanks very much for your review. please help check below.
The
Hi Tomasz,
Thanks very much for you suggestion and explain so detail.
please help check below.
On Fri, 2015-03-27 at 18:41 +0900, Tomasz Figa wrote:
Hi Yong Wu,
Sorry for long delay, I had to figure out some time to look at this again.
On Wed, Mar 18, 2015 at 8:22 PM, Yong Wu
On Tue, Apr 14, 2015 at 3:31 PM, Yong Wu yong...@mediatek.com wrote:
+
+ piommu-protect_va = devm_kmalloc(piommu-dev,
MTK_PROTECT_PA_ALIGN*2,
style: Operators like * should have space on both sides.
+ GFP_KERNEL);
Shouldn't
Hi Yong Wu,
Sorry for long delay, I had to figure out some time to look at this again.
On Wed, Mar 18, 2015 at 8:22 PM, Yong Wu wrote:
>>
>> > + imudev = piommu->dev;
>> > +
>> > + spin_lock_irqsave(>portlock, flags);
>>
>> What is protected by this spinlock?
> We
Hi Yong Wu,
Sorry for long delay, I had to figure out some time to look at this again.
On Wed, Mar 18, 2015 at 8:22 PM, Yong Wu yong...@mediatek.com wrote:
+ imudev = piommu-dev;
+
+ spin_lock_irqsave(priv-portlock, flags);
What is protected by this spinlock?
On 18/03/15 11:22, Yong Wu wrote:
Hi Tomasz,
Thanks very much for your review. please help check below.
The others I will fix in the next version.
Hi Robin,
There are some place I would like you can have a look and give me
some suggestion.
On Wed, 2015-03-11 at 19:53 +0900, Tomasz Figa
On 18/03/15 11:22, Yong Wu wrote:
Hi Tomasz,
Thanks very much for your review. please help check below.
The others I will fix in the next version.
Hi Robin,
There are some place I would like you can have a look and give me
some suggestion.
On Wed, 2015-03-11 at 19:53 +0900, Tomasz Figa
Hi Tomasz,
Thanks very much for your review. please help check below.
The others I will fix in the next version.
Hi Robin,
There are some place I would like you can have a look and give me
some suggestion.
On Wed, 2015-03-11 at 19:53 +0900, Tomasz Figa wrote:
> Hi,
>
> Please find next
Hi Tomasz,
Thanks very much for your review. please help check below.
The others I will fix in the next version.
Hi Robin,
There are some place I would like you can have a look and give me
some suggestion.
On Wed, 2015-03-11 at 19:53 +0900, Tomasz Figa wrote:
Hi,
Please find next part
On Mon, Mar 09, 2015 at 12:11:43PM +, Yong Wu wrote:
> On Fri, 2015-03-06 at 10:58 +, Will Deacon wrote:
> > On Fri, Mar 06, 2015 at 10:48:17AM +, yong...@mediatek.com wrote:
> > > From: Yong Wu
> > >
> > > This patch adds support for mediatek m4u (MultiMedia Memory Management
> > >
On Mon, Mar 09, 2015 at 12:11:43PM +, Yong Wu wrote:
On Fri, 2015-03-06 at 10:58 +, Will Deacon wrote:
On Fri, Mar 06, 2015 at 10:48:17AM +, yong...@mediatek.com wrote:
From: Yong Wu yong...@mediatek.com
This patch adds support for mediatek m4u (MultiMedia Memory
Dear Tomasz,
Thanks very much for review so detail!
Please check my reply below. Others I will fix it in the next
version.
And I have got your comment of [2/5]. Do you have plan for the
other patch?
On Sun, 2015-03-08 at 13:12 +0900, Tomasz Figa wrote:
> Hi Yong Wu,
>
Dear Tomasz,
Thanks very much for review so detail!
Please check my reply below. Others I will fix it in the next
version.
And I have got your comment of [2/5]. Do you have plan for the
other patch?
On Sun, 2015-03-08 at 13:12 +0900, Tomasz Figa wrote:
Hi Yong Wu,
Hi,
Please find next part of my comments inline.
On Fri, Mar 6, 2015 at 7:48 PM, wrote:
[snip]
> +/*
> + * pimudev is a global var for dma_alloc_coherent.
> + * It is not accepatable, we will delete it if "domain_alloc" is enabled
It looks like we indeed need to use dma_alloc_coherent() and
Hi,
Please find next part of my comments inline.
On Fri, Mar 6, 2015 at 7:48 PM, yong...@mediatek.com wrote:
[snip]
+/*
+ * pimudev is a global var for dma_alloc_coherent.
+ * It is not accepatable, we will delete it if domain_alloc is enabled
It looks like we indeed need to use
On Tue, Mar 10, 2015 at 12:41 PM, Yingjoe Chen
wrote:
> On Tue, 2015-03-10 at 02:00 +0900, Tomasz Figa wrote:
>> On Mon, Mar 9, 2015 at 11:46 PM, Yingjoe Chen
>> wrote:
>> > On Mon, 2015-03-09 at 20:11 +0900, Tomasz Figa wrote:
>> > <...>
>> >> > +/*
>> >> > + * pimudev is a global var for
On Tue, 2015-03-10 at 02:00 +0900, Tomasz Figa wrote:
> On Mon, Mar 9, 2015 at 11:46 PM, Yingjoe Chen
> wrote:
> > On Mon, 2015-03-09 at 20:11 +0900, Tomasz Figa wrote:
> > <...>
> >> > +/*
> >> > + * pimudev is a global var for dma_alloc_coherent.
> >> > + * It is not accepatable, we will
On Mon, Mar 9, 2015 at 11:46 PM, Yingjoe Chen wrote:
> On Mon, 2015-03-09 at 20:11 +0900, Tomasz Figa wrote:
> <...>
>> > +/*
>> > + * pimudev is a global var for dma_alloc_coherent.
>> > + * It is not accepatable, we will delete it if "domain_alloc" is enabled
>> > + */
>> > +static struct
On Mon, Mar 09 2015 at 05:16:26 AM, Yong Wu wrote:
> Dear Mitchel,
> Thanks very much for your review.
>
> On Fri, 2015-03-06 at 09:15 -0800, Mitchel Humpherys wrote:
>> On Fri, Mar 06 2015 at 02:48:17 AM, wrote:
>> > From: Yong Wu
>> >
>> > This patch adds support for mediatek m4u
On Mon, 2015-03-09 at 20:11 +0900, Tomasz Figa wrote:
<...>
> > +/*
> > + * pimudev is a global var for dma_alloc_coherent.
> > + * It is not accepatable, we will delete it if "domain_alloc" is enabled
> > + */
> > +static struct device *pimudev;
>
> This is indeed not acceptable. Could you
Dear Mitchel,
Thanks very much for your review.
On Fri, 2015-03-06 at 09:15 -0800, Mitchel Humpherys wrote:
> On Fri, Mar 06 2015 at 02:48:17 AM, wrote:
> > From: Yong Wu
> >
> > This patch adds support for mediatek m4u (MultiMedia Memory Management
> > Unit).
> > Currently this only
Dear Will,
On Fri, 2015-03-06 at 10:58 +, Will Deacon wrote:
> On Fri, Mar 06, 2015 at 10:48:17AM +, yong...@mediatek.com wrote:
> > From: Yong Wu
> >
> > This patch adds support for mediatek m4u (MultiMedia Memory Management
> > Unit).
> > Currently this only supports m4u gen 2 with 2
Hi,
You can find part 2 of my comments inline.
On Fri, Mar 6, 2015 at 7:48 PM, wrote:
[snip]
> +static irqreturn_t mtk_iommu_isr(int irq, void *dev_id)
> +{
> + struct iommu_domain *domain = dev_id;
> + struct mtk_iommu_domain *mtkdomain = domain->priv;
> + struct
Hi Yong Wu,
On Fri, Mar 6, 2015 at 6:48 PM, wrote:
> From: Yong Wu
>
> This patch adds support for mediatek m4u (MultiMedia Memory Management Unit).
> Currently this only supports m4u gen 2 with 2 levels of page table on mt8173.
>
> Signed-off-by: Yong Wu
> ---
> drivers/iommu/Kconfig
Dear Mitchel,
Thanks very much for your review.
On Fri, 2015-03-06 at 09:15 -0800, Mitchel Humpherys wrote:
On Fri, Mar 06 2015 at 02:48:17 AM, yong...@mediatek.com wrote:
From: Yong Wu yong...@mediatek.com
This patch adds support for mediatek m4u (MultiMedia Memory Management
Hi,
You can find part 2 of my comments inline.
On Fri, Mar 6, 2015 at 7:48 PM, yong...@mediatek.com wrote:
[snip]
+static irqreturn_t mtk_iommu_isr(int irq, void *dev_id)
+{
+ struct iommu_domain *domain = dev_id;
+ struct mtk_iommu_domain *mtkdomain = domain-priv;
+
Dear Will,
On Fri, 2015-03-06 at 10:58 +, Will Deacon wrote:
On Fri, Mar 06, 2015 at 10:48:17AM +, yong...@mediatek.com wrote:
From: Yong Wu yong...@mediatek.com
This patch adds support for mediatek m4u (MultiMedia Memory Management
Unit).
Currently this only supports m4u gen
On Mon, 2015-03-09 at 20:11 +0900, Tomasz Figa wrote:
...
+/*
+ * pimudev is a global var for dma_alloc_coherent.
+ * It is not accepatable, we will delete it if domain_alloc is enabled
+ */
+static struct device *pimudev;
This is indeed not acceptable. Could you replace
On Mon, Mar 09 2015 at 05:16:26 AM, Yong Wu yong...@mediatek.com wrote:
Dear Mitchel,
Thanks very much for your review.
On Fri, 2015-03-06 at 09:15 -0800, Mitchel Humpherys wrote:
On Fri, Mar 06 2015 at 02:48:17 AM, yong...@mediatek.com wrote:
From: Yong Wu yong...@mediatek.com
On Mon, Mar 9, 2015 at 11:46 PM, Yingjoe Chen yingjoe.c...@mediatek.com wrote:
On Mon, 2015-03-09 at 20:11 +0900, Tomasz Figa wrote:
...
+/*
+ * pimudev is a global var for dma_alloc_coherent.
+ * It is not accepatable, we will delete it if domain_alloc is enabled
+ */
+static struct
On Tue, 2015-03-10 at 02:00 +0900, Tomasz Figa wrote:
On Mon, Mar 9, 2015 at 11:46 PM, Yingjoe Chen yingjoe.c...@mediatek.com
wrote:
On Mon, 2015-03-09 at 20:11 +0900, Tomasz Figa wrote:
...
+/*
+ * pimudev is a global var for dma_alloc_coherent.
+ * It is not accepatable, we will
On Tue, Mar 10, 2015 at 12:41 PM, Yingjoe Chen
yingjoe.c...@mediatek.com wrote:
On Tue, 2015-03-10 at 02:00 +0900, Tomasz Figa wrote:
On Mon, Mar 9, 2015 at 11:46 PM, Yingjoe Chen yingjoe.c...@mediatek.com
wrote:
On Mon, 2015-03-09 at 20:11 +0900, Tomasz Figa wrote:
...
+/*
+ *
Hi Yong Wu,
On Fri, Mar 6, 2015 at 6:48 PM, yong...@mediatek.com wrote:
From: Yong Wu yong...@mediatek.com
This patch adds support for mediatek m4u (MultiMedia Memory Management Unit).
Currently this only supports m4u gen 2 with 2 levels of page table on mt8173.
Signed-off-by: Yong Wu
Hi Yong Wu,
Thanks for this series. Please see my comments inline.
On Fri, Mar 6, 2015 at 7:48 PM, wrote:
> From: Yong Wu
>
> This patch adds support for mediatek m4u (MultiMedia Memory Management Unit).
> Currently this only supports m4u gen 2 with 2 levels of page table on mt8173.
[snip]
Hi Yong Wu,
Thanks for this series. Please see my comments inline.
On Fri, Mar 6, 2015 at 7:48 PM, yong...@mediatek.com wrote:
From: Yong Wu yong...@mediatek.com
This patch adds support for mediatek m4u (MultiMedia Memory Management Unit).
Currently this only supports m4u gen 2 with 2
On Fri, Mar 06 2015 at 02:48:17 AM, wrote:
> From: Yong Wu
>
> This patch adds support for mediatek m4u (MultiMedia Memory Management Unit).
> Currently this only supports m4u gen 2 with 2 levels of page table on mt8173.
[...]
> +static int mtk_iommu_invalidate_tlb(const struct mtk_iommu_info
On Fri, Mar 06, 2015 at 10:48:17AM +, yong...@mediatek.com wrote:
> From: Yong Wu
>
> This patch adds support for mediatek m4u (MultiMedia Memory Management Unit).
> Currently this only supports m4u gen 2 with 2 levels of page table on mt8173.
[...]
> diff --git
From: Yong Wu
This patch adds support for mediatek m4u (MultiMedia Memory Management Unit).
Currently this only supports m4u gen 2 with 2 levels of page table on mt8173.
Signed-off-by: Yong Wu
---
drivers/iommu/Kconfig | 11 +
drivers/iommu/Makefile | 1 +
On Fri, Mar 06, 2015 at 10:48:17AM +, yong...@mediatek.com wrote:
From: Yong Wu yong...@mediatek.com
This patch adds support for mediatek m4u (MultiMedia Memory Management Unit).
Currently this only supports m4u gen 2 with 2 levels of page table on mt8173.
[...]
diff --git
On Fri, Mar 06 2015 at 02:48:17 AM, yong...@mediatek.com wrote:
From: Yong Wu yong...@mediatek.com
This patch adds support for mediatek m4u (MultiMedia Memory Management Unit).
Currently this only supports m4u gen 2 with 2 levels of page table on mt8173.
[...]
+static int
From: Yong Wu yong...@mediatek.com
This patch adds support for mediatek m4u (MultiMedia Memory Management Unit).
Currently this only supports m4u gen 2 with 2 levels of page table on mt8173.
Signed-off-by: Yong Wu yong...@mediatek.com
---
drivers/iommu/Kconfig | 11 +
50 matches
Mail list logo
