Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-05-03 Thread Stefan Agner
On 2017-05-02 04:18, Marek Vasut wrote: > On 05/02/2017 11:17 AM, Boris Brezillon wrote: >> Hi Han, >> >> On Fri, 21 Apr 2017 13:29:16 -0500 >> Han Xu wrote: >> > But then, adding the type would only require 2-3 lines of change if I add it to the

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-05-03 Thread Stefan Agner
On 2017-05-02 04:18, Marek Vasut wrote: > On 05/02/2017 11:17 AM, Boris Brezillon wrote: >> Hi Han, >> >> On Fri, 21 Apr 2017 13:29:16 -0500 >> Han Xu wrote: >> > But then, adding the type would only require 2-3 lines of change if I add it to the GPMI_IS_MX6 macro... >>>

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-05-02 Thread Marek Vasut
On 05/02/2017 11:17 AM, Boris Brezillon wrote: > Hi Han, > > On Fri, 21 Apr 2017 13:29:16 -0500 > Han Xu wrote: > >>> But then, adding the type would only require 2-3 lines of change if I >>> add it to the GPMI_IS_MX6 macro... >> >> Then at least add

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-05-02 Thread Marek Vasut
On 05/02/2017 11:17 AM, Boris Brezillon wrote: > Hi Han, > > On Fri, 21 Apr 2017 13:29:16 -0500 > Han Xu wrote: > >>> But then, adding the type would only require 2-3 lines of change if I >>> add it to the GPMI_IS_MX6 macro... >> >> Then at least add a comment because

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-05-02 Thread Boris Brezillon
Hi Han, On Fri, 21 Apr 2017 13:29:16 -0500 Han Xu wrote: > >> > > But then, adding the type would only require 2-3 lines of change if I > > add it to the GPMI_IS_MX6 macro... > > Then at least add a comment because using type = IMX6SX right under >

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-05-02 Thread Boris Brezillon
Hi Han, On Fri, 21 Apr 2017 13:29:16 -0500 Han Xu wrote: > >> > > But then, adding the type would only require 2-3 lines of change if I > > add it to the GPMI_IS_MX6 macro... > > Then at least add a comment because using type = IMX6SX right under > gpmi_data_mx7d can

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-21 Thread Stefan Agner
On 2017-04-21 06:08, Marek Vasut wrote: > On 04/21/2017 05:15 AM, Stefan Agner wrote: >> On 2017-04-20 19:03, Marek Vasut wrote: >>> On 04/21/2017 03:07 AM, Stefan Agner wrote: Add support for i.MX 7 SoC. The i.MX 7 has a slightly different clock architecture requiring only two clocks to

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-21 Thread Stefan Agner
On 2017-04-21 06:08, Marek Vasut wrote: > On 04/21/2017 05:15 AM, Stefan Agner wrote: >> On 2017-04-20 19:03, Marek Vasut wrote: >>> On 04/21/2017 03:07 AM, Stefan Agner wrote: Add support for i.MX 7 SoC. The i.MX 7 has a slightly different clock architecture requiring only two clocks to

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-21 Thread Han Xu
On Fri, Apr 21, 2017 at 12:38 PM, Stefan Agner wrote: > On 2017-04-21 10:22, Marek Vasut wrote: >> On 04/21/2017 06:19 PM, Stefan Agner wrote: >>> On 2017-04-21 06:08, Marek Vasut wrote: On 04/21/2017 05:15 AM, Stefan Agner wrote: > On 2017-04-20 19:03, Marek Vasut

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-21 Thread Han Xu
On Fri, Apr 21, 2017 at 12:38 PM, Stefan Agner wrote: > On 2017-04-21 10:22, Marek Vasut wrote: >> On 04/21/2017 06:19 PM, Stefan Agner wrote: >>> On 2017-04-21 06:08, Marek Vasut wrote: On 04/21/2017 05:15 AM, Stefan Agner wrote: > On 2017-04-20 19:03, Marek Vasut wrote: >> On

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-21 Thread Marek Vasut
On 04/21/2017 06:19 PM, Stefan Agner wrote: > On 2017-04-21 06:08, Marek Vasut wrote: >> On 04/21/2017 05:15 AM, Stefan Agner wrote: >>> On 2017-04-20 19:03, Marek Vasut wrote: On 04/21/2017 03:07 AM, Stefan Agner wrote: > Add support for i.MX 7 SoC. The i.MX 7 has a slightly different

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-21 Thread Marek Vasut
On 04/21/2017 06:19 PM, Stefan Agner wrote: > On 2017-04-21 06:08, Marek Vasut wrote: >> On 04/21/2017 05:15 AM, Stefan Agner wrote: >>> On 2017-04-20 19:03, Marek Vasut wrote: On 04/21/2017 03:07 AM, Stefan Agner wrote: > Add support for i.MX 7 SoC. The i.MX 7 has a slightly different

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-21 Thread Stefan Agner
On 2017-04-21 10:22, Marek Vasut wrote: > On 04/21/2017 06:19 PM, Stefan Agner wrote: >> On 2017-04-21 06:08, Marek Vasut wrote: >>> On 04/21/2017 05:15 AM, Stefan Agner wrote: On 2017-04-20 19:03, Marek Vasut wrote: > On 04/21/2017 03:07 AM, Stefan Agner wrote: >> Add support for

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-21 Thread Stefan Agner
On 2017-04-21 10:22, Marek Vasut wrote: > On 04/21/2017 06:19 PM, Stefan Agner wrote: >> On 2017-04-21 06:08, Marek Vasut wrote: >>> On 04/21/2017 05:15 AM, Stefan Agner wrote: On 2017-04-20 19:03, Marek Vasut wrote: > On 04/21/2017 03:07 AM, Stefan Agner wrote: >> Add support for

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-21 Thread Marek Vasut
On 04/21/2017 05:15 AM, Stefan Agner wrote: > On 2017-04-20 19:03, Marek Vasut wrote: >> On 04/21/2017 03:07 AM, Stefan Agner wrote: >>> Add support for i.MX 7 SoC. The i.MX 7 has a slightly different >>> clock architecture requiring only two clocks to be referenced. >>> The IP is slightly

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-21 Thread Marek Vasut
On 04/21/2017 05:15 AM, Stefan Agner wrote: > On 2017-04-20 19:03, Marek Vasut wrote: >> On 04/21/2017 03:07 AM, Stefan Agner wrote: >>> Add support for i.MX 7 SoC. The i.MX 7 has a slightly different >>> clock architecture requiring only two clocks to be referenced. >>> The IP is slightly

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-20 Thread Stefan Agner
On 2017-04-20 19:03, Marek Vasut wrote: > On 04/21/2017 03:07 AM, Stefan Agner wrote: >> Add support for i.MX 7 SoC. The i.MX 7 has a slightly different >> clock architecture requiring only two clocks to be referenced. >> The IP is slightly different compared to i.MX 6SoloX, but currently >> none

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-20 Thread Stefan Agner
On 2017-04-20 19:03, Marek Vasut wrote: > On 04/21/2017 03:07 AM, Stefan Agner wrote: >> Add support for i.MX 7 SoC. The i.MX 7 has a slightly different >> clock architecture requiring only two clocks to be referenced. >> The IP is slightly different compared to i.MX 6SoloX, but currently >> none

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-20 Thread Marek Vasut
On 04/21/2017 03:07 AM, Stefan Agner wrote: > Add support for i.MX 7 SoC. The i.MX 7 has a slightly different > clock architecture requiring only two clocks to be referenced. > The IP is slightly different compared to i.MX 6SoloX, but currently > none of this differences are in use so there is no

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-20 Thread Marek Vasut
On 04/21/2017 03:07 AM, Stefan Agner wrote: > Add support for i.MX 7 SoC. The i.MX 7 has a slightly different > clock architecture requiring only two clocks to be referenced. > The IP is slightly different compared to i.MX 6SoloX, but currently > none of this differences are in use so there is no

[PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-20 Thread Stefan Agner
Add support for i.MX 7 SoC. The i.MX 7 has a slightly different clock architecture requiring only two clocks to be referenced. The IP is slightly different compared to i.MX 6SoloX, but currently none of this differences are in use so there is no detection needed and the driver can reuse IS_MX6SX.

[PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-20 Thread Stefan Agner
Add support for i.MX 7 SoC. The i.MX 7 has a slightly different clock architecture requiring only two clocks to be referenced. The IP is slightly different compared to i.MX 6SoloX, but currently none of this differences are in use so there is no detection needed and the driver can reuse IS_MX6SX.