Re: [PATCH 2/5] net: MOXA ART: connect to PHY and add ethtool support

2013-11-22 Thread Ben Hutchings
On Fri, 2013-11-22 at 15:57 +0100, Jonas Jensen wrote: > The kernel now has a MDIO bus driver and a phy_driver (RTL8201CP), > connect to this PHY using OF and add ethtool support. > > Signed-off-by: Jonas Jensen > --- > > Notes: > Applies to next-20131122 > >

Re: [PATCH 2/5] net: MOXA ART: connect to PHY and add ethtool support

2013-11-22 Thread Florian Fainelli
Hello Jonas, > + if (!priv->phy_dev) > + return -ENODEV; This should not be required since you will fail probing the interface if you cannot connect to the PHY device. > + > + return phy_ethtool_gset(priv->phy_dev, cmd); > +} > + > +static int

Re: [PATCH 2/5] net: MOXA ART: connect to PHY and add ethtool support

2013-11-22 Thread Florian Fainelli
2013/11/22 Jonas Jensen : > On 22 November 2013 15:57, Jonas Jensen wrote: >> drivers/net/ethernet/moxa/moxart_ether.c | 179 >> ++- >> drivers/net/ethernet/moxa/moxart_ether.h | 1 + >> 2 files changed, 179 insertions(+), 1 deletion(-) > > I see now I forgot to

Re: [PATCH 2/5] net: MOXA ART: connect to PHY and add ethtool support

2013-11-22 Thread Jonas Jensen
On 22 November 2013 15:57, Jonas Jensen wrote: > drivers/net/ethernet/moxa/moxart_ether.c | 179 > ++- > drivers/net/ethernet/moxa/moxart_ether.h | 1 + > 2 files changed, 179 insertions(+), 1 deletion(-) I see now I forgot to include the devicetree binding

[PATCH 2/5] net: MOXA ART: connect to PHY and add ethtool support

2013-11-22 Thread Jonas Jensen
The kernel now has a MDIO bus driver and a phy_driver (RTL8201CP), connect to this PHY using OF and add ethtool support. Signed-off-by: Jonas Jensen --- Notes: Applies to next-20131122 drivers/net/ethernet/moxa/moxart_ether.c | 179 ++-

[PATCH 2/5] net: MOXA ART: connect to PHY and add ethtool support

2013-11-22 Thread Jonas Jensen
The kernel now has a MDIO bus driver and a phy_driver (RTL8201CP), connect to this PHY using OF and add ethtool support. Signed-off-by: Jonas Jensen jonas.jen...@gmail.com --- Notes: Applies to next-20131122 drivers/net/ethernet/moxa/moxart_ether.c | 179 ++-

Re: [PATCH 2/5] net: MOXA ART: connect to PHY and add ethtool support

2013-11-22 Thread Jonas Jensen
On 22 November 2013 15:57, Jonas Jensen jonas.jen...@gmail.com wrote: drivers/net/ethernet/moxa/moxart_ether.c | 179 ++- drivers/net/ethernet/moxa/moxart_ether.h | 1 + 2 files changed, 179 insertions(+), 1 deletion(-) I see now I forgot to include the

Re: [PATCH 2/5] net: MOXA ART: connect to PHY and add ethtool support

2013-11-22 Thread Florian Fainelli
2013/11/22 Jonas Jensen jonas.jen...@gmail.com: On 22 November 2013 15:57, Jonas Jensen jonas.jen...@gmail.com wrote: drivers/net/ethernet/moxa/moxart_ether.c | 179 ++- drivers/net/ethernet/moxa/moxart_ether.h | 1 + 2 files changed, 179 insertions(+), 1

Re: [PATCH 2/5] net: MOXA ART: connect to PHY and add ethtool support

2013-11-22 Thread Florian Fainelli
Hello Jonas, + if (!priv-phy_dev) + return -ENODEV; This should not be required since you will fail probing the interface if you cannot connect to the PHY device. + + return phy_ethtool_gset(priv-phy_dev, cmd); +} + +static int moxart_set_settings(struct

Re: [PATCH 2/5] net: MOXA ART: connect to PHY and add ethtool support

2013-11-22 Thread Ben Hutchings
On Fri, 2013-11-22 at 15:57 +0100, Jonas Jensen wrote: The kernel now has a MDIO bus driver and a phy_driver (RTL8201CP), connect to this PHY using OF and add ethtool support. Signed-off-by: Jonas Jensen jonas.jen...@gmail.com --- Notes: Applies to next-20131122