Re: [PATCH 2/5] perf hists: Exchange order of comparing items when collapsing hists

2012-12-07 Thread Jiri Olsa
On Fri, Dec 07, 2012 at 05:38:22PM +0900, Namhyung Kim wrote: > Hi Arnaldo, > SNIP > @@ -739,6 +739,10 @@ static struct hist_entry *hists__add_dummy_entry(struct > hists *hists, > > cmp = hist_entry__collapse(he, pair); > > + if (sort__need_collapse) > +

Re: [PATCH 2/5] perf hists: Exchange order of comparing items when collapsing hists

2012-12-07 Thread Namhyung Kim
Hi Arnaldo, On Thu, 6 Dec 2012 16:09:20 -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 06, 2012 at 05:53:25PM +0100, Jiri Olsa escreveu: >> On Fri, Dec 07, 2012 at 12:09:38AM +0900, Namhyung Kim wrote: >> > From: Namhyung Kim >> > >> > When comparing entries for collapsing put the given

Re: [PATCH 2/5] perf hists: Exchange order of comparing items when collapsing hists

2012-12-07 Thread Namhyung Kim
Hi Arnaldo, On Thu, 6 Dec 2012 16:09:20 -0300, Arnaldo Carvalho de Melo wrote: Em Thu, Dec 06, 2012 at 05:53:25PM +0100, Jiri Olsa escreveu: On Fri, Dec 07, 2012 at 12:09:38AM +0900, Namhyung Kim wrote: From: Namhyung Kim namhyung@lge.com When comparing entries for collapsing put the

Re: [PATCH 2/5] perf hists: Exchange order of comparing items when collapsing hists

2012-12-07 Thread Jiri Olsa
On Fri, Dec 07, 2012 at 05:38:22PM +0900, Namhyung Kim wrote: Hi Arnaldo, SNIP @@ -739,6 +739,10 @@ static struct hist_entry *hists__add_dummy_entry(struct hists *hists, cmp = hist_entry__collapse(he, pair); + if (sort__need_collapse) +

Re: [PATCH 2/5] perf hists: Exchange order of comparing items when collapsing hists

2012-12-06 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 06, 2012 at 05:53:25PM +0100, Jiri Olsa escreveu: > On Fri, Dec 07, 2012 at 12:09:38AM +0900, Namhyung Kim wrote: > > From: Namhyung Kim > > > > When comparing entries for collapsing put the given entry first, and > > then the iterated entry. This is not the case of

Re: [PATCH 2/5] perf hists: Exchange order of comparing items when collapsing hists

2012-12-06 Thread Jiri Olsa
On Fri, Dec 07, 2012 at 12:09:38AM +0900, Namhyung Kim wrote: > From: Namhyung Kim > > When comparing entries for collapsing put the given entry first, and > then the iterated entry. This is not the case of hist_entry__cmp() > when called if given sort keys don't require collapsing. So change

[PATCH 2/5] perf hists: Exchange order of comparing items when collapsing hists

2012-12-06 Thread Namhyung Kim
From: Namhyung Kim When comparing entries for collapsing put the given entry first, and then the iterated entry. This is not the case of hist_entry__cmp() when called if given sort keys don't require collapsing. So change the order for the sake of consistency. It will be required for matching

[PATCH 2/5] perf hists: Exchange order of comparing items when collapsing hists

2012-12-06 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com When comparing entries for collapsing put the given entry first, and then the iterated entry. This is not the case of hist_entry__cmp() when called if given sort keys don't require collapsing. So change the order for the sake of consistency. It will be

Re: [PATCH 2/5] perf hists: Exchange order of comparing items when collapsing hists

2012-12-06 Thread Jiri Olsa
On Fri, Dec 07, 2012 at 12:09:38AM +0900, Namhyung Kim wrote: From: Namhyung Kim namhyung@lge.com When comparing entries for collapsing put the given entry first, and then the iterated entry. This is not the case of hist_entry__cmp() when called if given sort keys don't require

Re: [PATCH 2/5] perf hists: Exchange order of comparing items when collapsing hists

2012-12-06 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 06, 2012 at 05:53:25PM +0100, Jiri Olsa escreveu: On Fri, Dec 07, 2012 at 12:09:38AM +0900, Namhyung Kim wrote: From: Namhyung Kim namhyung@lge.com When comparing entries for collapsing put the given entry first, and then the iterated entry. This is not the case of