Re: [PATCH 2/5] seqlock: Fold seqcount_LOCKNAME_t definition

2020-07-29 Thread peterz
On Wed, Jul 29, 2020 at 05:33:41PM +0200, pet...@infradead.org wrote: > On Wed, Jul 29, 2020 at 03:55:07PM +0100, Matthew Wilcox wrote: > > On Wed, Jul 29, 2020 at 03:52:51PM +0200, Peter Zijlstra wrote: > > > Manual repetition is boring and error prone. > > > > Yes, but generated functions are ha

Re: [PATCH 2/5] seqlock: Fold seqcount_LOCKNAME_t definition

2020-07-29 Thread peterz
On Wed, Jul 29, 2020 at 03:55:07PM +0100, Matthew Wilcox wrote: > On Wed, Jul 29, 2020 at 03:52:51PM +0200, Peter Zijlstra wrote: > > Manual repetition is boring and error prone. > > Yes, but generated functions are hard to grep for, and I'm pretty sure > that kernel-doc doesn't know how to expand

Re: [PATCH 2/5] seqlock: Fold seqcount_LOCKNAME_t definition

2020-07-29 Thread Matthew Wilcox
On Wed, Jul 29, 2020 at 03:52:51PM +0200, Peter Zijlstra wrote: > Manual repetition is boring and error prone. Yes, but generated functions are hard to grep for, and I'm pretty sure that kernel-doc doesn't know how to expand macros into comments that it can then extract documentation from. I've b

Re: [PATCH 2/5] seqlock: Fold seqcount_LOCKNAME_t definition

2020-07-29 Thread Ahmed S. Darwish
On Wed, Jul 29, 2020 at 03:52:51PM +0200, Peter Zijlstra wrote: > Manual repetition is boring and error prone. > > Signed-off-by: Peter Zijlstra (Intel) > --- ... > +/** > + * typedef seqcount_LOCKNAME_t - sequence counter with spinlock associated

[PATCH 2/5] seqlock: Fold seqcount_LOCKNAME_t definition

2020-07-29 Thread Peter Zijlstra
Manual repetition is boring and error prone. Signed-off-by: Peter Zijlstra (Intel) --- include/linux/seqlock.h | 140 +--- 1 file changed, 38 insertions(+), 102 deletions(-) --- a/include/linux/seqlock.h +++ b/include/linux/seqlock.h @@ -150,21 +150,