Re: [PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...)

2014-05-20 Thread walter harms
Am 18.05.2014 19:27, schrieb Joe Perches: > On Sun, 2014-05-18 at 18:19 +0100, Masaru Nomura wrote: >> Remove prohibited space and fix line over 80 characters of >> memset(...) to meet kernel coding style. > [] >> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c >>

Re: [PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...)

2014-05-20 Thread walter harms
Am 18.05.2014 19:27, schrieb Joe Perches: On Sun, 2014-05-18 at 18:19 +0100, Masaru Nomura wrote: Remove prohibited space and fix line over 80 characters of memset(...) to meet kernel coding style. [] diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c

Re: [PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...)

2014-05-18 Thread Masaru Nomura
>> - memset (peer, 0, sizeof (*peer)); /* NULL pointers/clear flags >> etc */ >> + memset(peer, 0, sizeof(*peer)); /* NULL pointers/clear flags etc */ > > It looks like this memset is unnecessary > as it's already zeroed by LIBCFS_ALLOC-> >

Re: [PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...)

2014-05-18 Thread Joe Perches
On Sun, 2014-05-18 at 18:19 +0100, Masaru Nomura wrote: > Remove prohibited space and fix line over 80 characters of > memset(...) to meet kernel coding style. [] > diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c > b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c [] > @@

[PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...)

2014-05-18 Thread Masaru Nomura
Remove prohibited space and fix line over 80 characters of memset(...) to meet kernel coding style. Signed-off-by: Masaru Nomura --- .../staging/lustre/lnet/klnds/socklnd/socklnd.c|2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...)

2014-05-18 Thread Masaru Nomura
Remove prohibited space and fix line over 80 characters of memset(...) to meet kernel coding style. Signed-off-by: Masaru Nomura massa.nom...@gmail.com --- .../staging/lustre/lnet/klnds/socklnd/socklnd.c|2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...)

2014-05-18 Thread Joe Perches
On Sun, 2014-05-18 at 18:19 +0100, Masaru Nomura wrote: Remove prohibited space and fix line over 80 characters of memset(...) to meet kernel coding style. [] diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c [] @@ -113,7

Re: [PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...)

2014-05-18 Thread Masaru Nomura
- memset (peer, 0, sizeof (*peer)); /* NULL pointers/clear flags etc */ + memset(peer, 0, sizeof(*peer)); /* NULL pointers/clear flags etc */ It looks like this memset is unnecessary as it's already zeroed by LIBCFS_ALLOC- LIBCFS_ALLOC_GFP-LIBCFS_ALLOC_POST-memset. It