Re: [PATCH 2/5] zram: partial IO refactoring

Hi Sergey, On Tue, Apr 04, 2017 at 11:17:06AM +0900, Sergey Senozhatsky wrote: > Hello, > > On (04/03/17 14:17), Minchan Kim wrote: > > +static bool zram_special_page_read(struct zram *zram, u32 index, > > + struct page *page, > > + unsigned

Re: [PATCH 2/5] zram: partial IO refactoring

Hi Sergey, On Tue, Apr 04, 2017 at 11:17:06AM +0900, Sergey Senozhatsky wrote: > Hello, > > On (04/03/17 14:17), Minchan Kim wrote: > > +static bool zram_special_page_read(struct zram *zram, u32 index, > > + struct page *page, > > + unsigned

Re: [PATCH 2/5] zram: partial IO refactoring

Hello, On (04/03/17 14:17), Minchan Kim wrote: > +static bool zram_special_page_read(struct zram *zram, u32 index, > + struct page *page, > + unsigned int offset, unsigned int len) > +{ > + struct zram_meta *meta = zram->meta; > + > +

Re: [PATCH 2/5] zram: partial IO refactoring

Hello, On (04/03/17 14:17), Minchan Kim wrote: > +static bool zram_special_page_read(struct zram *zram, u32 index, > + struct page *page, > + unsigned int offset, unsigned int len) > +{ > + struct zram_meta *meta = zram->meta; > + > +

Re: [PATCH 2/5] zram: partial IO refactoring

On 04/03/2017 09:12 AM, Minchan Kim wrote: > Hi Mika, > > On Mon, Apr 03, 2017 at 08:52:33AM +0300, Mika Penttilä wrote: >> >> Hi! >> >> On 04/03/2017 08:17 AM, Minchan Kim wrote: >>> For architecture(PAGE_SIZE > 4K), zram have supported partial IO. >>> However, the mixed code for handling

Re: [PATCH 2/5] zram: partial IO refactoring

On 04/03/2017 09:12 AM, Minchan Kim wrote: > Hi Mika, > > On Mon, Apr 03, 2017 at 08:52:33AM +0300, Mika Penttilä wrote: >> >> Hi! >> >> On 04/03/2017 08:17 AM, Minchan Kim wrote: >>> For architecture(PAGE_SIZE > 4K), zram have supported partial IO. >>> However, the mixed code for handling

Re: [PATCH 2/5] zram: partial IO refactoring

Hi Mika, On Mon, Apr 03, 2017 at 08:52:33AM +0300, Mika Penttilä wrote: > > Hi! > > On 04/03/2017 08:17 AM, Minchan Kim wrote: > > For architecture(PAGE_SIZE > 4K), zram have supported partial IO. > > However, the mixed code for handling normal/partial IO is too mess, > > error-prone to modify

Re: [PATCH 2/5] zram: partial IO refactoring

Hi Mika, On Mon, Apr 03, 2017 at 08:52:33AM +0300, Mika Penttilä wrote: > > Hi! > > On 04/03/2017 08:17 AM, Minchan Kim wrote: > > For architecture(PAGE_SIZE > 4K), zram have supported partial IO. > > However, the mixed code for handling normal/partial IO is too mess, > > error-prone to modify

Re: [PATCH 2/5] zram: partial IO refactoring

Hi! On 04/03/2017 08:17 AM, Minchan Kim wrote: > For architecture(PAGE_SIZE > 4K), zram have supported partial IO. > However, the mixed code for handling normal/partial IO is too mess, > error-prone to modify IO handler functions with upcoming feature > so this patch aims for cleaning up zram's

Re: [PATCH 2/5] zram: partial IO refactoring

Hi! On 04/03/2017 08:17 AM, Minchan Kim wrote: > For architecture(PAGE_SIZE > 4K), zram have supported partial IO. > However, the mixed code for handling normal/partial IO is too mess, > error-prone to modify IO handler functions with upcoming feature > so this patch aims for cleaning up zram's

[PATCH 2/5] zram: partial IO refactoring

For architecture(PAGE_SIZE > 4K), zram have supported partial IO. However, the mixed code for handling normal/partial IO is too mess, error-prone to modify IO handler functions with upcoming feature so this patch aims for cleaning up zram's IO handling functions. Signed-off-by: Minchan Kim

[PATCH 2/5] zram: partial IO refactoring

For architecture(PAGE_SIZE > 4K), zram have supported partial IO. However, the mixed code for handling normal/partial IO is too mess, error-prone to modify IO handler functions with upcoming feature so this patch aims for cleaning up zram's IO handling functions. Signed-off-by: Minchan Kim ---