Re: [PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs

2015-04-16 Thread Matias Bjørling
On 04/16/2015 01:34 PM, Paul Bolle wrote: On Thu, 2015-04-16 at 12:23 +0200, Matias Bjørling wrote: On 04/16/2015 11:10 AM, Paul Bolle wrote: A few things I spotted (while actually fiddling with 3/5). Thanks. I'll fix them up. Please note that just using #ifdef instead of #if is not all

Re: [PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs

2015-04-16 Thread Paul Bolle
On Thu, 2015-04-16 at 12:23 +0200, Matias Bjørling wrote: > On 04/16/2015 11:10 AM, Paul Bolle wrote: > > A few things I spotted (while actually fiddling with 3/5). > > Thanks. I'll fix them up. Please note that just using #ifdef instead of #if is not all that's needed. See, I had some fun

Re: [PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs

2015-04-16 Thread Matias Bjørling
On 04/16/2015 11:10 AM, Paul Bolle wrote: A few things I spotted (while actually fiddling with 3/5). Thanks. I'll fix them up. On Wed, 2015-04-15 at 14:34 +0200, Matias Bjørling wrote: index f3dd028..58a8a71 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -221,6 +221,9 @@ static void

Re: [PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs

2015-04-16 Thread Paul Bolle
A few things I spotted (while actually fiddling with 3/5). On Wed, 2015-04-15 at 14:34 +0200, Matias Bjørling wrote: > index f3dd028..58a8a71 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -221,6 +221,9 @@ static void blk_mq_rq_ctx_init(struct request_queue *q, > struct blk_mq_ctx

Re: [PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs

2015-04-16 Thread Paul Bolle
A few things I spotted (while actually fiddling with 3/5). On Wed, 2015-04-15 at 14:34 +0200, Matias Bjørling wrote: index f3dd028..58a8a71 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -221,6 +221,9 @@ static void blk_mq_rq_ctx_init(struct request_queue *q, struct blk_mq_ctx *ctx,

Re: [PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs

2015-04-16 Thread Matias Bjørling
On 04/16/2015 11:10 AM, Paul Bolle wrote: A few things I spotted (while actually fiddling with 3/5). Thanks. I'll fix them up. On Wed, 2015-04-15 at 14:34 +0200, Matias Bjørling wrote: index f3dd028..58a8a71 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -221,6 +221,9 @@ static void

Re: [PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs

2015-04-16 Thread Paul Bolle
On Thu, 2015-04-16 at 12:23 +0200, Matias Bjørling wrote: On 04/16/2015 11:10 AM, Paul Bolle wrote: A few things I spotted (while actually fiddling with 3/5). Thanks. I'll fix them up. Please note that just using #ifdef instead of #if is not all that's needed. See, I had some fun playing

Re: [PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs

2015-04-16 Thread Matias Bjørling
On 04/16/2015 01:34 PM, Paul Bolle wrote: On Thu, 2015-04-16 at 12:23 +0200, Matias Bjørling wrote: On 04/16/2015 11:10 AM, Paul Bolle wrote: A few things I spotted (while actually fiddling with 3/5). Thanks. I'll fix them up. Please note that just using #ifdef instead of #if is not all

[PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs

2015-04-15 Thread Matias Bjørling
Open-channel SSDs are devices that share responsibilities with the host in order to implement and maintain features that typical SSDs keep strictly in firmware. These include (i) the Flash Translation Layer (FTL), (ii) bad block management, and (iii) hardware units such as the flash controller,

[PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs

2015-04-15 Thread Matias Bjørling
Open-channel SSDs are devices that share responsibilities with the host in order to implement and maintain features that typical SSDs keep strictly in firmware. These include (i) the Flash Translation Layer (FTL), (ii) bad block management, and (iii) hardware units such as the flash controller,