Re: [PATCH 2/6] LBS: fix uninitialized swapper_space

2007-09-26 Thread Christoph Lameter
On Wed, 26 Sep 2007, Hugh Dickins wrote: > Probably better, yes. In -mm Peter is doing an #ifdef CONFIG_SWAP > bdi_init() on swapper_space. Would make sense to do both together, > perhaps move them to a swapper_space_init() in swap_state.c, saving > his #ifdef too. I suggest leave such

Re: [PATCH 2/6] LBS: fix uninitialized swapper_space

2007-09-26 Thread Hugh Dickins
On Mon, 24 Sep 2007, Christoph Lameter wrote: > On Fri, 21 Sep 2007, Hugh Dickins wrote: > > > Swapping crashed immediately: must initialize new fields of swapper_space. > > Thanks for finding that. It may be better though to use the new > mapping_setup() function instead? That way there is no

Re: [PATCH 2/6] LBS: fix uninitialized swapper_space

2007-09-26 Thread Hugh Dickins
On Mon, 24 Sep 2007, Christoph Lameter wrote: On Fri, 21 Sep 2007, Hugh Dickins wrote: Swapping crashed immediately: must initialize new fields of swapper_space. Thanks for finding that. It may be better though to use the new mapping_setup() function instead? That way there is no #ifdef.

Re: [PATCH 2/6] LBS: fix uninitialized swapper_space

2007-09-26 Thread Christoph Lameter
On Wed, 26 Sep 2007, Hugh Dickins wrote: Probably better, yes. In -mm Peter is doing an #ifdef CONFIG_SWAP bdi_init() on swapper_space. Would make sense to do both together, perhaps move them to a swapper_space_init() in swap_state.c, saving his #ifdef too. I suggest leave such cleanups

Re: [PATCH 2/6] LBS: fix uninitialized swapper_space

2007-09-24 Thread Christoph Lameter
On Fri, 21 Sep 2007, Hugh Dickins wrote: > Swapping crashed immediately: must initialize new fields of swapper_space. Thanks for finding that. It may be better though to use the new mapping_setup() function instead? That way there is no #ifdef. - To unsubscribe from this list: send the line

Re: [PATCH 2/6] LBS: fix uninitialized swapper_space

2007-09-24 Thread Christoph Lameter
On Fri, 21 Sep 2007, Hugh Dickins wrote: Swapping crashed immediately: must initialize new fields of swapper_space. Thanks for finding that. It may be better though to use the new mapping_setup() function instead? That way there is no #ifdef. - To unsubscribe from this list: send the line

[PATCH 2/6] LBS: fix uninitialized swapper_space

2007-09-21 Thread Hugh Dickins
Swapping crashed immediately: must initialize new fields of swapper_space. Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> --- 2.6.23-rc6-lbs/mm/swap_state.c 2007-07-26 19:49:58.0 +0100 +++ linux/mm/swap_state.c 2007-09-13 20:00:45.0 +0100 @@ -42,6 +42,10 @@ struct

[PATCH 2/6] LBS: fix uninitialized swapper_space

2007-09-21 Thread Hugh Dickins
Swapping crashed immediately: must initialize new fields of swapper_space. Signed-off-by: Hugh Dickins [EMAIL PROTECTED] --- 2.6.23-rc6-lbs/mm/swap_state.c 2007-07-26 19:49:58.0 +0100 +++ linux/mm/swap_state.c 2007-09-13 20:00:45.0 +0100 @@ -42,6 +42,10 @@ struct