Re: [PATCH 2/6] arch/sparc: Define config parameter CPU_BIG_ENDIAN

2017-05-19 Thread Babu Moger
On 5/18/2017 9:26 PM, David Miller wrote: From: Babu Moger Date: Thu, 18 May 2017 18:36:06 -0600 @@ -91,6 +91,10 @@ config ARCH_DEFCONFIG config ARCH_PROC_KCORE_TEXT def_bool y +config CPU_BIG_ENDIAN + bool + default y if SPARC64 + 32-bit

Re: [PATCH 2/6] arch/sparc: Define config parameter CPU_BIG_ENDIAN

2017-05-19 Thread Babu Moger
On 5/18/2017 9:26 PM, David Miller wrote: From: Babu Moger Date: Thu, 18 May 2017 18:36:06 -0600 @@ -91,6 +91,10 @@ config ARCH_DEFCONFIG config ARCH_PROC_KCORE_TEXT def_bool y +config CPU_BIG_ENDIAN + bool + default y if SPARC64 + 32-bit sparc is big-endian too

Re: [PATCH 2/6] arch/sparc: Define config parameter CPU_BIG_ENDIAN

2017-05-18 Thread David Miller
From: Babu Moger Date: Thu, 18 May 2017 18:36:06 -0600 > @@ -91,6 +91,10 @@ config ARCH_DEFCONFIG > config ARCH_PROC_KCORE_TEXT > def_bool y > > +config CPU_BIG_ENDIAN > + bool > + default y if SPARC64 > + 32-bit sparc is big-endian too :-) So please

Re: [PATCH 2/6] arch/sparc: Define config parameter CPU_BIG_ENDIAN

2017-05-18 Thread David Miller
From: Babu Moger Date: Thu, 18 May 2017 18:36:06 -0600 > @@ -91,6 +91,10 @@ config ARCH_DEFCONFIG > config ARCH_PROC_KCORE_TEXT > def_bool y > > +config CPU_BIG_ENDIAN > + bool > + default y if SPARC64 > + 32-bit sparc is big-endian too :-) So please don't use SPARC64 for the

[PATCH 2/6] arch/sparc: Define config parameter CPU_BIG_ENDIAN

2017-05-18 Thread Babu Moger
Found this problem while enabling queued rwlock on SPARC. The parameter CONFIG_CPU_BIG_ENDIAN is used to clear the specific byte in qrwlock structure. Without this parameter, we clear the wrong byte. Here is the code. static inline u8 *__qrwlock_write_byte(struct qrwlock *lock) { return

[PATCH 2/6] arch/sparc: Define config parameter CPU_BIG_ENDIAN

2017-05-18 Thread Babu Moger
Found this problem while enabling queued rwlock on SPARC. The parameter CONFIG_CPU_BIG_ENDIAN is used to clear the specific byte in qrwlock structure. Without this parameter, we clear the wrong byte. Here is the code. static inline u8 *__qrwlock_write_byte(struct qrwlock *lock) { return