Re: [PATCH 2/6] eventfsfs: initialize the tracefs inode properly

On Tue, 30 Jan 2024 14:48:02 -0500 Steven Rostedt wrote: > The ti is allocated from fs/tracefs/inode.c that has: > > static struct inode *tracefs_alloc_inode(struct super_block *sb) > { > struct tracefs_inode *ti; > > ti = kmem_cache_alloc(tracefs_inode_cachep, GFP_KERNEL); I

Re: [PATCH 2/6] eventfsfs: initialize the tracefs inode properly

On Tue, 30 Jan 2024 11:03:51 -0800 Linus Torvalds wrote: > @@ -328,7 +328,9 @@ static struct dentry *create_file(const char *name, > umode_t mode, > inode->i_ino = EVENTFS_FILE_INODE_INO; > > ti = get_tracefs(inode); > - ti->flags |= TRACEFS_EVENT_INODE; > + ti->flags =

Re: [PATCH 2/6] eventfsfs: initialize the tracefs inode properly

On Tue, 30 Jan 2024 11:03:51 -0800 Linus Torvalds wrote: > The tracefs-specific fields in the inode were not initialized before the > inode was exposed to others through the dentry with 'd_instantiate()'. > > And the ->flags file was initialized incorrectly with a '|=', when the > old value was

[PATCH 2/6] eventfsfs: initialize the tracefs inode properly

The tracefs-specific fields in the inode were not initialized before the inode was exposed to others through the dentry with 'd_instantiate()'. And the ->flags file was initialized incorrectly with a '|=', when the old value was stale. It should have just been a straight assignment. Move the